You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+42-6Lines changed: 42 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -29,11 +29,11 @@ Owners of the repository will watch out for and review new PRs.
29
29
30
30
If comments have been given in a review, they have to be addressed before merging.
31
31
32
-
After addressing review comments, don’t forget to add a comment in the PR afterward, so everyone gets notified by Github and knows to re-review.
32
+
After addressing review comments, don't forget to add a comment in the PR afterward, so everyone gets notified by Github and knows to re-review.
33
33
34
34
## CI
35
35
36
-
####GitHub actions
36
+
### GitHub actions
37
37
38
38
-[Next Dockerimage](https://github.com/devfile/devworkspace-operator/blob/main/.github/workflows/dockerimage-next.yml) action builds main branch and pushes it to [quay.io/devfile/devworkspace-controller:next](https://quay.io/repository/devfile/devworkspace-controller?tag=latest&tab=tags)
39
39
-[Code Coverage Report](./.github/workflows/code-coverage.yml) action creates a code coverage report using [codecov.io](https://about.codecov.io/).
@@ -50,14 +50,34 @@ To build, test and debug the DevWorkspace Operator the following development too
50
50
- git
51
51
- sed
52
52
- jq
53
-
- yq (python-yq from https://github.com/kislyuk/yq#installation, other distributions may not work)
53
+
- yq (python-yq from <https://github.com/kislyuk/yq#installation>, other distributions may not work)
54
54
- skopeo (if building the OLM catalogsource)
55
55
- podman or docker
56
56
57
57
Note: kustomize `v4.0.5` is required for most tasks. It is downloaded automatically to the `.kustomize` folder in this
58
58
repo when required. This downloaded version is used regardless of whether or not kustomize is already installed on the
59
59
system.
60
60
61
+
#### macOS Specific Issues
62
+
63
+
On macOS, the default `make` utility might be outdated, leading to issues with some `Makefile` targets. To resolve this, it's recommended to install a newer version of `make` using Homebrew and ensure it's prioritized in your system's `$PATH`.
64
+
65
+
> Note: `make` version `4.4.1` has been tested and confirmed to resolve these issues.
66
+
67
+
1. Install Homebrew `make`:
68
+
69
+
```bash
70
+
brew install make
71
+
```
72
+
73
+
2. Add the Homebrew `make` executable to your `$PATH` by adding the following line to your shell configuration file (e.g., `~/.zshrc`, `~/.bash_profile`):
6. Finally deploys the CRDs and the controller to the current cluster:
116
-
```
144
+
145
+
```bash
117
146
make install # <== this command copies the CRDs definition
118
147
# creates the namespace for the controller in the cluster
119
148
# downloads and runs kustomize to build the manifests
@@ -140,7 +169,8 @@ make run
140
169
```
141
170
142
171
> Note: The operator requires internet access from containers to work. By default, `crc setup` may not provision this, so it's necessary to configure DNS for Docker:
143
-
>```
172
+
>
173
+
>```text
144
174
># /etc/docker/daemon.json
145
175
> {
146
176
> "dns": ["192.168.0.1"]
@@ -191,26 +221,32 @@ make disconnect-debug-webhook-server
191
221
make update_devworkspace_api update_devworkspace_crds # first commit
192
222
make generate_all # second commit
193
223
```
224
+
194
225
Example of the devfile API update [PR](https://github.com/devfile/devworkspace-operator/pull/797)
195
226
196
227
### Remove controller from your K8s/OS Cluster
228
+
197
229
To uninstall the controller and associated CRDs, use the Makefile uninstall rule:
230
+
198
231
```bash
199
232
make uninstall
200
233
```
234
+
201
235
This will delete all custom resource definitions created for the controller, as well as the `devworkspace-controller` namespace.
202
236
203
237
### Build a custom OLM bundle
204
238
205
239
In order to build a custom bundle, the following environment variables should be set:
240
+
206
241
| variable | purpose | default value |
207
242
|---|---|---|
208
243
|`DWO_BUNDLE_IMG`| Image used for Operator bundle image |`quay.io/devfile/devworkspace-operator-bundle:next`|
209
244
|`DWO_INDEX_IMG`| Image used for Operator index image |`quay.io/devfile/devworkspace-operator-index:next`|
210
245
|`DEFAULT_DWO_IMG`| Image used for controller when generating defaults |`quay.io/devfile/devworkspace-controller:next`|
211
246
212
247
To build the index image and register its catalogsource to the cluster, run
213
-
```
248
+
249
+
```bash
214
250
make generate_olm_bundle_yaml build_bundle_and_index register_catalogsource
0 commit comments