Skip to content

Commit 1324d33

Browse files
committed
Fixup documentation and remove mention of MPIX_CONT_PERSISTENT
MPIX_CONT_PERSISTENT will not be part of the first proposal and has been removed. Signed-off-by: Joseph Schuchart <[email protected]>
1 parent cc2fc0d commit 1324d33

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

ompi/mpiext/continue/c/mpiext_continue_c.h

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,16 @@
2525
*/
2626
#define MPIX_CONT_REQBUF_VOLATILE 1<<0
2727

28-
/**
29-
* the continuation is persistent (only valid with persistent requests)
30-
* TODO: not implemented yet
31-
*/
32-
#define MPIX_CONT_PERSISTENT 1<<1
33-
3428
/*
35-
* mark the continuation request as poll-only, i.e., only execute continuations
29+
* Mark the continuation request as poll-only, i.e., only execute continuations
3630
* when testing/waiting for the continuation request to complete
3731
*/
3832
#define MPIX_CONT_POLL_ONLY 1<<2
3933

40-
/* Wwhether the execution of continuations is deferred in MPI_Continue or
34+
/* Whether the execution of continuations is deferred in MPI_Continue or
4135
* MPI_Continueall if all operations are complete.
42-
* By default, continuations eligible for execution are invoked immediately. */
36+
* By default, continuations eligible for execution are invoked immediately
37+
* if the continuation request is active. */
4338
#define MPIX_CONT_DEFER_COMPLETE 1<<3
4439

4540
/* whether failed continuations will be invoked and passed the error code
@@ -56,7 +51,11 @@
5651
typedef int (MPIX_Continue_cb_function)(int rc, void *cb_data);
5752

5853
/**
59-
* Initialize a continuation request.
54+
* Initialize a continuation request. The request can be used when attaching continuation to one or more
55+
* operation requests (\sa MPIX_Continue and \sa MPIX_Continueall). The request must be active for
56+
* continuation callbacks registered with it to be executed, i.e., the request must be started (e.g., using MPI_Start)
57+
* before callbacks are executed.
58+
*
6059
* \param flags 0 or \ref MPIX_CONT_POLL_ONLY
6160
* \param max_poll the maximum number of continuations to execute when testing
6261
* the continuation request for completion or zero for
@@ -77,7 +76,7 @@ OMPI_DECLSPEC int MPIX_Continue_init(int flags, int max_poll, MPI_Info info, MPI
7776
* \param request the request representing the the operation to attach a continuation to
7877
* \param cb the callback to invoke upon completion, with signature \ref MPIX_Continue_cb_function
7978
* \param cb_data the user-data to pass to the callback
80-
* \param flags 0 or OR-combination of \ref MPIX_CONT_REQBUF_VOLATILE, \ref MPIX_CONT_PERSISTENT,
79+
* \param flags 0 or OR-combination of \ref MPIX_CONT_REQBUF_VOLATILE,
8180
* \ref MPIX_CONT_DEFER_COMPLETE, \ref MPIX_CONT_INVOKE_FAILED
8281
* \param status MPI_STATUS_IGNORE or a pointer to a status object that will be a filled before the callback is invoked
8382
* \param cont_req a continuation request created through \ref MPIX_Continue_init
@@ -94,7 +93,7 @@ OMPI_DECLSPEC int MPIX_Continue(MPI_Request *request, MPIX_Continue_cb_function
9493
* \param requests the requests representing the the operations to attach a continuation to
9594
* \param cb the callback to invoke upon completion of all operations, with signature \ref MPIX_Continue_cb_function
9695
* \param cb_data the user-data to pass to the callback
97-
* \param flags 0 or OR-combination of \ref MPIX_CONT_REQBUF_VOLATILE, \ref MPIX_CONT_PERSISTENT,
96+
* \param flags 0 or OR-combination of \ref MPIX_CONT_REQBUF_VOLATILE,
9897
* \ref MPIX_CONT_DEFER_COMPLETE, \ref MPIX_CONT_INVOKE_FAILED
9998
* \param status MPI_STATUS_IGNORE or a pointer to a status object that will be a filled before the callback is invoked
10099
* \param cont_req a continuation request created through \ref MPIX_Continue_init

0 commit comments

Comments
 (0)