-
Notifications
You must be signed in to change notification settings - Fork 22
refactor(ledger): Extend class IcrcLedgerCanister with common IcrcCanister
#1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AntonioVentilii
merged 14 commits into
main
from
feat-ledger/Extend-class-IcrcLedgerCanister-with-common-IcrcCanister
Nov 21, 2025
Merged
refactor(ledger): Extend class IcrcLedgerCanister with common IcrcCanister
#1288
AntonioVentilii
merged 14 commits into
main
from
feat-ledger/Extend-class-IcrcLedgerCanister-with-common-IcrcCanister
Nov 21, 2025
+3
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
…with-common-IcrcCanister
IcrcLedgerCanister with common IcrcCanisterIcrcLedgerCanister with common IcrcCanister
peterpeterparker
approved these changes
Nov 21, 2025
Member
peterpeterparker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Class
IcrcLedgerCanistercan actually extend abstractIcrcCanister(see PR #1285).And in fact, the method to fetch the balance is the exact same that is already developed in
IcrcCanister.Changes
IcrcLedgerCanisterfromCanistertoIcrcCanister.balancemethod.Tests
No more tests needed, since the method
balanceis already tested forIcrcCanister.