Skip to content

BUG: A motoko upgrade should never have the option to ignore stable compatiblity errors. #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crusso opened this issue Apr 2, 2025 · 0 comments · Fixed by #4213
Closed

BUG: A motoko upgrade should never have the option to ignore stable compatiblity errors. #4183

crusso opened this issue Apr 2, 2025 · 0 comments · Fixed by #4213

Comments

@crusso
Copy link
Contributor

crusso commented Apr 2, 2025 •
edited
Loading

The code here:

sdk/src/dfx/src/lib/operations/canister/install_canister.rs

Line 115 in 5a823d1

if !skip_consent && canister_info.is_motoko() && matches!(mode, InstallMode::Upgrade { .. }) {

is dangerous because it permits the user ignore any stable compatibility errors which may lead to loss of data.

This is more dangerous than ignoring the candid compatibility error, because users can always fix the candid interface with an upgrade, but once data is lost, it's gone or corrupted forever.

Is it possible to skip/ask for consent on stable compatibility warnings only but never, ever ignore stable compatibility errors?

@luc-blaeser - do you agree with proposal?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: always require stable compatible upgrades (no skip_consent) dfinity/sdk
1 participant
@crusso