Commit 11d307f
authored
fix(docker): prevent host node_modules from polluting builds + non-interactive pnpm (#3)
Three things compounding caused `make up` to fail with
ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY:
1. No .dockerignore meant 'COPY ui/ ./' was overlaying the host's
resolved ui/node_modules onto the image's freshly-installed one,
triggering pnpm's drift-detection.
2. With drift detected, pnpm decided node_modules needed to be
removed and reinstalled but refused to do so without a TTY to
confirm.
3. Backend builds were also susceptible to host-state contamination
from .venv, .pytest_cache, __pycache__, .cerebro.json, etc.
Fixes:
- Add .dockerignore at repo root. Excludes node_modules, .venv,
__pycache__, .pytest_cache, .mypy_cache, .ruff_cache, dist/,
.gitnexus/, AGENTS.md, .docs/, openspec/, tests/, .github/,
/data/, *.cerebro.json, *.db, .env (keep .env.example). Image
contexts now ship only what the build actually needs.
- Set ENV CI=true in docker/ui.Dockerfile so pnpm operates
non-interactively if it ever decides to nuke node_modules anyway.
- Set ENV CI=true in docker/backend.Dockerfile for symmetry and to
keep any uv prompt path predictable.
Verified locally: `docker compose build` succeeds for both images,
`make up` brings both containers online, `curl localhost:3000`
returns 200 with the UI's index.html.1 parent c8da55a commit 11d307f
3 files changed
Lines changed: 99 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
7 | 11 | | |
8 | 12 | | |
9 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
7 | 15 | | |
8 | 16 | | |
9 | 17 | | |
| |||
0 commit comments