Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Anoncreds verifier support #1359

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

✨ Anoncreds verifier support #1359

wants to merge 31 commits into from
+804 −67

Conversation

cl0ete
Copy link
Collaborator

@cl0ete cl0ete commented Mar 4, 2025 •
edited by ff137
Loading

Add anoncreds verify support

@cl0ete cl0ete self-assigned this Mar 4, 2025
@cl0ete cl0ete force-pushed the verify-anoncreds branch 5 times, most recently from f3b59e4 to a128986 Compare March 10, 2025 12:20
@ff137 ff137 changed the base branch from anoncreds to master March 10, 2025 20:26
@ff137 ff137 changed the title 🚧 5 Verify anoncreds 🚧 Anoncreds verifier Mar 10, 2025
@cl0ete cl0ete force-pushed the verify-anoncreds branch from 4b78b71 to 0e6e3d6 Compare March 11, 2025 08:05
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 11, 2025
View reviewed changes
app/routes/revocation.py Outdated
@@ -195,7 +196,8 @@
if not result:
bound_logger.debug("No revocations to publish.")
return RevokedResponse()

# TODO The anoncreds response seems to be broken, looks like agent response model not what it's

Check notice

Code scanning / Pylintpython3 (reported by Codacy)

TODO The anoncreds response seems to be broken, looks like agent response model not what it's

TODO The anoncreds response seems to be broken, looks like agent response model not what it's
@ff137 ff137 force-pushed the verify-anoncreds branch 2 times, most recently from 158fe21 to 3420e0d Compare March 11, 2025 21:02
@ff137 ff137 force-pushed the verify-anoncreds branch from 78b3d7c to fafb7c0 Compare March 12, 2025 13:29
@cl0ete cl0ete changed the title 🚧 Anoncreds verifier ✨ Anoncreds verifier Mar 13, 2025
@ff137 ff137 changed the title ✨ Anoncreds verifier ✨ Anoncreds verifier support Mar 13, 2025
@ff137 ff137 added the enhancement New feature or request label Mar 13, 2025
@ff137 ff137 marked this pull request as ready for review March 13, 2025 09:32
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 13, 2025
View reviewed changes
app/tests/services/onboarding/test_onboarding.py Outdated
@@ -263,7 +263,7 @@
verifier_label="verifier_name", verifier_controller=mock_agent_controller
)

assert_that(onboard_result).has_did(did_key)
assert_that(onboard_result).has_did(did_key.split("#")[0])

Check warning

Code scanning / Pylintpython3 (reported by Codacy)

instead

instead
@github-actions GitHub Actions
Copy link

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   wallet.py36489%100–105
app/routes
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
app/services/onboarding
   tenants.py634922%30–103, 113–143
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py866920%36–70, 92–122, 132–181
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/services
   nats_jetstream.py36489%56, 60, 64, 68
shared/util
   api_router.py14193%17
   mock_agent_controller.py57689%25, 78–82
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL528939393% 

Tests Skipped Failures Errors Time
1020 6 💤 0 ❌ 0 🔥 5m 59s ⏱️

@github-actions GitHub Actions
Copy link

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   wallet.py36489%100–105
app/routes
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
app/services/onboarding
   tenants.py634922%30–103, 113–143
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py181233%14–34
   check_endorser_connection.py10460%14–24
   credentials.py14286%13, 18
   retry_method.py362433%20–35, 68–114
   save_exchange_record.py13192%29
   string.py15473%15–16, 20, 24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14750%21–39
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py866920%36–70, 92–122, 132–181
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/services
   nats_jetstream.py36489%56, 60, 64, 68
shared/util
   api_router.py14193%17
   mock_agent_controller.py57689%25, 78–82
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL528941992% 

Tests Skipped Failures Errors Time
1020 46 💤 0 ❌ 0 🔥 6m 33s ⏱️

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cl0ete cl0ete

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cl0ete @ff137