Skip to content

Commit 23b5a4f

Browse files
committed
Fix Node.js versions used during testing.
- Use older Node.js to install due to webpack issues. - Use target Node.js version to test.
1 parent dd1c202 commit 23b5a4f

File tree

1 file changed

+19
-12
lines changed

1 file changed

+19
-12
lines changed

.github/workflows/main.yml

+19-12
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,18 @@ jobs:
1010
matrix:
1111
node-version: [6.x, 8.x, 10.x, 12.x, 14.x, 16.x, 18.x, 20.x, 22.x]
1212
steps:
13-
- uses: actions/checkout@v2
13+
- uses: actions/checkout@v4
14+
# FIXME: Install/build with 16.x until webpack is updated
15+
- name: Use Node.js 16.x
16+
uses: actions/setup-node@v4
17+
with:
18+
node-version: 16.x
19+
- run: npm install
20+
# FIXME: Run tests with target version until webpack is updated
1421
- name: Use Node.js ${{ matrix.node-version }}
15-
uses: actions/setup-node@v1
22+
uses: actions/setup-node@v4
1623
with:
1724
node-version: ${{ matrix.node-version }}
18-
- run: npm install
1925
- name: Run test with Node.js ${{ matrix.node-version }}
2026
run: npm run test-node
2127
test-karma:
@@ -26,9 +32,9 @@ jobs:
2632
node-version: [14.x]
2733
bundler: [webpack, browserify]
2834
steps:
29-
- uses: actions/checkout@v2
35+
- uses: actions/checkout@v4
3036
- name: Use Node.js ${{ matrix.node-version }}
31-
uses: actions/setup-node@v1
37+
uses: actions/setup-node@v4
3238
with:
3339
node-version: ${{ matrix.node-version }}
3440
- run: npm install
@@ -41,11 +47,11 @@ jobs:
4147
# timeout-minutes: 10
4248
# strategy:
4349
# matrix:
44-
# node-version: [14.x]
50+
# node-version: [16.x]
4551
# steps:
46-
# - uses: actions/checkout@v2
52+
# - uses: actions/checkout@v4
4753
# - name: Use Node.js ${{ matrix.node-version }}
48-
# uses: actions/setup-node@v1
54+
# uses: actions/setup-node@v4
4955
# with:
5056
# node-version: ${{ matrix.node-version }}
5157
# - run: npm install
@@ -56,18 +62,19 @@ jobs:
5662
timeout-minutes: 10
5763
strategy:
5864
matrix:
59-
node-version: [14.x]
65+
node-version: [16.x]
6066
steps:
61-
- uses: actions/checkout@v2
67+
- uses: actions/checkout@v4
6268
- name: Use Node.js ${{ matrix.node-version }}
63-
uses: actions/setup-node@v1
69+
uses: actions/setup-node@v4
6470
with:
6571
node-version: ${{ matrix.node-version }}
6672
- run: npm install
6773
- name: Generate coverage report
6874
run: npm run coverage-ci
6975
- name: Upload coverage to Codecov
70-
uses: codecov/codecov-action@v1
76+
uses: codecov/codecov-action@v4
7177
with:
7278
file: ./coverage/lcov.info
7379
fail_ci_if_error: true
80+
token: ${{ secrets.CODECOV_TOKEN }}

0 commit comments

Comments
 (0)