fix(deserializer): unable to create polymorphic relationship #298

Author: grahambates

lib/deserializer.js

@@ -1,6 +1,7 @@
 'use strict'
 
 var _ = require('lodash')
+var utils = require('./utils')
 
 function defaultBeforeDeserialize (options, cb) {
   cb(null, options)
@@ -79,6 +80,20 @@ function belongsToRelationships (options) {
       options.result[fkName] = null
     } else {
       options.result[fkName] = relationship.data.id
+      if (serverRelation.polymorphic) {
+        // Find the model which has a plural matching 'data.type'
+        // Allow case insensitive match
+        var relatedType = relationship.data.type.toLowerCase()
+        var modelName = _.findKey(model.app.models, function (model) {
+          var plural = utils.pluralForModel(model)
+          return plural.toLowerCase() === relatedType
+        })
+        if (!modelName) {
+          return false
+        }
+        var discriminator = serverRelation.polymorphic.discriminator
+        options.result[discriminator] = modelName
+      }
     }
   })
 }

test/belongsToPolymorphic.test.js

@@ -40,6 +40,8 @@ describe('loopback json api belongsTo polymorphic relationships', function () {
   })
 
   describe('File belonging to a Post', function () {
+    var postId
+
     beforeEach(function (done) {
       Post.create(
         {
@@ -48,6 +50,7 @@ describe('loopback json api belongsTo polymorphic relationships', function () {
         },
         function (err, post) {
           expect(err).to.equal(null)
+          postId = post.id
           FileModel.create(
             {
               fileName: 'blah.jpg',
@@ -105,5 +108,38 @@ describe('loopback json api belongsTo polymorphic relationships', function () {
         })
       }
     )
+
+    it(
+      'should define a relationship to Post when file is created via API',
+      function (done) {
+        request(app)
+          .post('/fileModels')
+          .send({
+            data: {
+              type: 'fileModels',
+              attributes: {
+                fileName: 'blah.jpg'
+              },
+              relationships: {
+                parent: {
+                  data: {
+                    id: postId,
+                    type: 'posts'
+                  }
+                }
+              }
+            }
+          })
+          .set('accept', 'application/vnd.api+json')
+          .set('content-type', 'application/json')
+          .expect(201)
+          .end(function (err, res) {
+            expect(err).to.equal(null)
+            expect(res.body).to.not.have.key('errors')
+            expect(res.body.data.relationships.parent).to.be.an('object')
+            done()
+          })
+      }
+    )
   })
 })

test/hasManyPolymorphic.test.js

@@ -103,5 +103,50 @@ describe('loopback json api hasMany polymorphic relationships', function () {
         })
       }
     )
+
+    it(
+      'should define a relationship to Resources when Post is created via API',
+      function (done) {
+        Resource.create(
+          {
+            fileName: 'blah.jpg'
+          },
+          function (err, resource) {
+            expect(err).to.equal(null)
+            request(app)
+              .post('/posts')
+              .send({
+                data: {
+                  type: 'posts',
+                  attributes: {
+                    fileName: 'blah.jpg'
+                  },
+                  relationships: {
+                    resources: {
+                      data: [
+                        {
+                          id: resource.id,
+                          type: 'resources'
+                        }
+                      ]
+                    }
+                  }
+                }
+              })
+              .set('accept', 'application/vnd.api+json')
+              .set('content-type', 'application/json')
+              .expect(201)
+              .end(function (err, res) {
+                expect(err).to.equal(null)
+                expect(res.body).to.not.have.key('errors')
+                expect(res.body.data.relationships.resources).to.be.an(
+                  'object'
+                )
+                done()
+              })
+          }
+        )
+      }
+    )
   })
 })