Skip to content

Commit dd1ed39

Browse files
Code Review comments addressed
1 parent 18a46e7 commit dd1ed39

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

Ring Buffer/RingBuffer.playground/Contents.swift

+10-3
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,20 @@ public struct RingBuffer<T> {
1313
@discardableResult
1414
public mutating func write(_ element: T) -> Bool {
1515
guard !isFull else { return false }
16-
defer { writeIndex += 1 }
16+
defer {
17+
writeIndex += 1
18+
}
1719
array[wrapped: writeIndex] = element
1820
return true
1921
}
2022

2123
/* Returns nil if the buffer is empty. */
2224
public mutating func read() -> T? {
2325
guard !isEmpty else { return nil }
24-
defer { array[wrapped: readIndex] = nil ; readIndex += 1 }
26+
defer {
27+
array[wrapped: readIndex] = nil
28+
readIndex += 1
29+
}
2530
return array[wrapped: readIndex]
2631
}
2732

@@ -47,7 +52,9 @@ extension RingBuffer: Sequence {
4752
var index = readIndex
4853
return AnyIterator {
4954
guard index < self.writeIndex else { return nil }
50-
defer { index += 1 }
55+
defer {
56+
index += 1
57+
}
5158
return self.array[wrapped: index]
5259
}
5360
}

Ring Buffer/RingBuffer.swift

+10-3
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,20 @@ public struct RingBuffer<T> {
2323
@discardableResult
2424
public mutating func write(_ element: T) -> Bool {
2525
guard !isFull else { return false }
26-
defer { writeIndex += 1 }
26+
defer {
27+
writeIndex += 1
28+
}
2729
array[wrapped: writeIndex] = element
2830
return true
2931
}
3032

3133
/* Returns nil if the buffer is empty. */
3234
public mutating func read() -> T? {
3335
guard !isEmpty else { return nil }
34-
defer { array[wrapped: readIndex] = nil ; readIndex += 1 }
36+
defer {
37+
array[wrapped: readIndex] = nil
38+
readIndex += 1
39+
}
3540
return array[wrapped: readIndex]
3641
}
3742

@@ -57,7 +62,9 @@ public extension RingBuffer: Sequence {
5762
var index = readIndex
5863
return AnyIterator {
5964
guard index < self.writeIndex else { return nil }
60-
defer { index += 1 }
65+
defer {
66+
index += 1
67+
}
6168
return self.array[wrapped: index]
6269
}
6370
}

0 commit comments

Comments
 (0)