Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proding profiles page of LMEL is the same as Dismoi #1178

Closed
MaartenLMEM opened this issue Nov 11, 2021 · 4 comments · Fixed by #1181
Closed

Proding profiles page of LMEL is the same as Dismoi #1178

MaartenLMEM opened this issue Nov 11, 2021 · 4 comments · Fixed by #1181
Assignees
Labels
Le Même en Local extensions Le Même en Local released

Comments

@MaartenLMEM
Copy link
Contributor

Problem :
https://proding-profiles.dismoi.io/eclaireurs : contributors page adress is the same for LMEL as for Dismoi. Therefore, the list of contributors is the same, while it should be a restricted list of local ones.

To reproduce :

  1. Install LMEM proding (or staging)
  2. onboarding opens
  3. choose contributors and validate
  4. it open list of contributor page : https://proding-profiles.dismoi.io/eclaireurs?pk_campaign=installed-contributors-list
@MaartenLMEM MaartenLMEM changed the title Proding profiles page of LMEL is the them as Dismoi Proding profiles page of LMEL is the same as Dismoi Nov 11, 2021
@JalilArfaoui JalilArfaoui self-assigned this Nov 11, 2021
@JalilArfaoui JalilArfaoui added the Le Même en Local extensions Le Même en Local label Nov 11, 2021
@JalilArfaoui
Copy link
Member

🎉 This issue has been resolved in version 3.93.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@prk-dismoi
Copy link

prk-dismoi commented Nov 18, 2021

An additional issue which might warrant its own ticket.
From abroad, my browser opens: https://lememe.fr/en/guides/?pk_campaign=installed upon installation of the latest Firefox proding extension (3.93.5)
@jalil, pls let me know if you prefer I open a separate ticket for this non-FR issue.

@JalilArfaoui
Copy link
Member

Yes, please @prk-dismoi so that we can keep track of what needs to be done

@prk-dismoi
Copy link

Yes, please @prk-dismoi so that we can keep track of what needs to be done

Thanks. Created an investigation ticket here: #1189
Once its clear what we do with EN I'll review the flows and write up precise tasks accordingly (if needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Le Même en Local extensions Le Même en Local released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants