Fix some build issues.

Author: iclanton

apps/heft/src/utilities/subprocess/SubprocessTerminator.ts

@@ -5,14 +5,6 @@ import { Executable } from '@rushstack/node-core-library';
 import * as child_process from 'child_process';
 import process from 'process';
 
-declare module 'child_process' {
-  /* eslint-disable */
-  interface ChildProcess {
-    exitCode?: number | null;
-  }
-  /* eslint-enable */
-}
-
 /**
  * Details about how the `child_process.ChildProcess` was created.
  */

apps/rush-lib/src/cli/scriptActions/BaseScriptAction.ts

@@ -82,7 +82,7 @@ export abstract class BaseScriptAction extends BaseRushAction {
             throw new Error(
               `${RushConstants.commandLineFilename} defines a parameter "${
                 (parameterJson as ParameterJson).longName
-              }"` + ` using an unsupported parameter kind "${(parameterJson as ParameterJson).parameterKind}"`
+              }" using an unsupported parameter kind "${(parameterJson as ParameterJson).parameterKind}"`
             );
         }
 

apps/rush-lib/src/logic/buildCache/ProjectBuildCache.ts

@@ -2,7 +2,7 @@
 // See LICENSE in the project root for license information.
 
 import * as path from 'path';
-import * as events from 'events';
+import events from 'events';
 import * as crypto from 'crypto';
 import type * as stream from 'stream';
 import * as tar from 'tar';

apps/rush-lib/src/utilities/TarExecutable.ts

@@ -4,7 +4,7 @@
 import * as path from 'path';
 import { Executable, FileSystem, FileWriter, Terminal } from '@rushstack/node-core-library';
 import { ChildProcess } from 'child_process';
-import * as events from 'events';
+import events from 'events';
 
 import { RushConfigurationProject } from '../api/RushConfigurationProject';
 import { EnvironmentConfiguration } from '../api/EnvironmentConfiguration';
@@ -151,8 +151,8 @@ export class TarExecutable {
       currentWorkingDirectory: currentWorkingDirectory
     });
 
-    childProcess.stdout.on('data', (chunk) => fileWriter.write(`[stdout] ${chunk}`));
-    childProcess.stderr.on('data', (chunk) => fileWriter.write(`[stderr] ${chunk}`));
+    childProcess.stdout?.on('data', (chunk) => fileWriter.write(`[stdout] ${chunk}`));
+    childProcess.stderr?.on('data', (chunk) => fileWriter.write(`[stderr] ${chunk}`));
 
     const [tarExitCode] = await events.once(childProcess, 'exit');
 

build-tests/api-extractor-lib1-test/package.json

@@ -10,7 +10,6 @@
   },
   "devDependencies": {
     "@microsoft/api-extractor": "workspace:*",
-    "@types/node": "12.20.24",
     "fs-extra": "~7.0.1",
     "typescript": "~2.9.2"
   }

build-tests/api-extractor-lib1-test/tsconfig.json

@@ -7,9 +7,8 @@
     "sourceMap": true,
     "experimentalDecorators": true,
     "strictNullChecks": true,
-    "types": ["node"],
     "lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],
     "outDir": "lib"
   },
-  "include": ["src/**/*.ts", "typings/tsd.d.ts"]
+  "include": ["src/**/*.ts"]
 }

build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml

@@ -1,5 +1,5 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
-  "pnpmShrinkwrapHash": "0bdff54ae475bbd646622ab3543a206dc49ba3cf",
+  "pnpmShrinkwrapHash": "37ed8324429452c58d3ab8468ca58080ef354ec5",
   "preferredVersionsHash": "fe0ea762c60633ea39d8abd6f7e0791352654f89"
 }

common/config/rush/pnpm-lock.yaml

@@ -28,12 +28,12 @@ export async function runAsync(command: string, params: string[]): Promise<IRunR
 async function _handleChildProcess(childProcess: child_process.ChildProcess): Promise<IRunResult> {
   return await new Promise((resolve: (result: IRunResult) => void) => {
     const stderr: string[] = [];
-    childProcess.stderr.on('data', (data: Buffer) => {
+    childProcess.stderr?.on('data', (data: Buffer) => {
       stderr.push(data.toString());
     });
 
     const stdout: string[] = [];
-    childProcess.stdout.on('data', (data: Buffer) => {
+    childProcess.stdout?.on('data', (data: Buffer) => {
       stdout.push(data.toString());
     });
 

common/config/rush/repo-state.json

@@ -98,7 +98,7 @@ export interface IJsonFileSaveOptions extends IJsonFileStringifyOptions {
   updateExistingFile?: boolean;
 }
 
-const DEFAULT_ENCODING = 'utf8';
+const DEFAULT_ENCODING: 'utf8' = 'utf8';
 
 /**
  * Utilities for reading/writing JSON files.