Skip to content

Commit c4337f1

Browse files
authored
clean up python 2 code (#976)
1 parent c763b97 commit c4337f1

27 files changed

+23
-63
lines changed

Diff for: docs/conf.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env python3
2-
# -*- coding: utf-8 -*-
2+
#
33
#
44
# Django REST framework JSON:API documentation build configuration file, created by
55
# sphinx-quickstart on Fri Jul 24 23:31:15 2015.

Diff for: example/api/resources/identity.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def posts(self, request):
3333
@action(detail=True)
3434
def manual_resource_name(self, request, *args, **kwargs):
3535
self.resource_name = "data"
36-
return super(Identity, self).retrieve(request, args, kwargs)
36+
return super().retrieve(request, args, kwargs)
3737

3838
@action(detail=True)
3939
def validation(self, request, *args, **kwargs):

Diff for: example/factories.py

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# -*- encoding: utf-8 -*-
2-
31
import factory
42
from faker import Factory as FakerFactory
53

Diff for: example/migrations/0001_initial.py

-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
# Generated by Django 1.9.5 on 2016-05-02 08:26
3-
from __future__ import unicode_literals
4-
51
import django.db.models.deletion
62
from django.db import migrations, models
73

Diff for: example/migrations/0002_taggeditem.py

-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
# Generated by Django 1.10.5 on 2017-02-01 08:34
3-
from __future__ import unicode_literals
4-
51
import django.db.models.deletion
62
from django.db import migrations, models
73

Diff for: example/migrations/0003_polymorphics.py

-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
# Generated by Django 1.11.1 on 2017-05-17 14:49
3-
from __future__ import unicode_literals
4-
51
import django.db.models.deletion
62
from django.db import migrations, models
73

Diff for: example/migrations/0004_auto_20171011_0631.py

-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
# Generated by Django 1.11.6 on 2017-10-11 06:31
3-
from __future__ import unicode_literals
4-
51
import django.db.models.deletion
62
from django.db import migrations, models
73

Diff for: example/models.py

-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
# -*- encoding: utf-8 -*-
2-
from __future__ import unicode_literals
3-
41
from django.contrib.contenttypes.fields import GenericForeignKey, GenericRelation
52
from django.contrib.contenttypes.models import ContentType
63
from django.db import models

Diff for: example/serializers.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class Meta:
8383

8484
class EntrySerializer(serializers.ModelSerializer):
8585
def __init__(self, *args, **kwargs):
86-
super(EntrySerializer, self).__init__(*args, **kwargs)
86+
super().__init__(*args, **kwargs)
8787
# to make testing more concise we'll only output the
8888
# `featured` field when it's requested via `include`
8989
request = kwargs.get("context", {}).get("request")
@@ -379,7 +379,7 @@ class Meta:
379379

380380
class CurrentProjectRelatedField(relations.PolymorphicResourceRelatedField):
381381
def get_attribute(self, instance):
382-
obj = super(CurrentProjectRelatedField, self).get_attribute(instance)
382+
obj = super().get_attribute(instance)
383383

384384
is_art = self.field_name == "current_art_project" and isinstance(
385385
obj, ArtProject

Diff for: example/tests/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def setUp(self):
1111
"""
1212
Create those users
1313
"""
14-
super(TestBase, self).setUp()
14+
super().setUp()
1515
self.create_users()
1616

1717
def create_user(self, username, email, password="pw", first_name="", last_name=""):

Diff for: example/tests/snapshots/snap_test_errors.py

-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
# snapshottest: v1 - https://goo.gl/zC4yUc
3-
from __future__ import unicode_literals
4-
51
from snapshottest import Snapshot
62

73
snapshots = Snapshot()

Diff for: example/tests/snapshots/snap_test_openapi.py

-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
# snapshottest: v1 - https://goo.gl/zC4yUc
3-
from __future__ import unicode_literals
4-
51
from snapshottest import Snapshot
62

73
snapshots = Snapshot()

Diff for: example/tests/test_format_keys.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class FormatKeysSetTests(TestBase):
1414
list_url = reverse("user-list")
1515

1616
def setUp(self):
17-
super(FormatKeysSetTests, self).setUp()
17+
super().setUp()
1818
self.detail_url = reverse("user-detail", kwargs={"pk": self.miles.pk})
1919

2020
def test_camelization(self):

Diff for: example/tests/test_generic_validation.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class GenericValidationTest(TestBase):
99
"""
1010

1111
def setUp(self):
12-
super(GenericValidationTest, self).setUp()
12+
super().setUp()
1313
self.url = reverse("user-validation", kwargs={"pk": self.miles.pk})
1414

1515
def test_generic_validation_error(self):

Diff for: example/tests/test_model_viewsets.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class ModelViewSetTests(TestBase):
1919
list_url = reverse("user-list")
2020

2121
def setUp(self):
22-
super(ModelViewSetTests, self).setUp()
22+
super().setUp()
2323
self.detail_url = reverse("user-detail", kwargs={"pk": self.miles.pk})
2424

2525
def test_key_in_list_result(self):

Diff for: example/tests/test_serializers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ def test_deserialize_many(self):
179179
print(serializer.data)
180180

181181

182-
class TestModelSerializer(object):
182+
class TestModelSerializer:
183183
def test_model_serializer_with_implicit_fields(self, comment, client):
184184
expected = {
185185
"data": {

Diff for: example/tests/unit/test_filter_schema_params.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class DummyEntryViewSet(EntryViewSet):
2222
def __init__(self, **kwargs):
2323
# dummy up self.request since PreloadIncludesMixin expects it to be defined
2424
self.request = None
25-
super(DummyEntryViewSet, self).__init__(**kwargs)
25+
super().__init__(**kwargs)
2626

2727

2828
def test_filters_get_schema_params():

Diff for: example/tests/unit/test_renderer_class_methods.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,12 @@ class CustomRenderer(JSONRenderer):
7070
@classmethod
7171
def extract_attributes(cls, fields, resource):
7272
cls.extract_attributes_was_overriden = True
73-
return super(CustomRenderer, cls).extract_attributes(fields, resource)
73+
return super().extract_attributes(fields, resource)
7474

7575
@classmethod
7676
def extract_relationships(cls, fields, resource, resource_instance):
7777
cls.extract_relationships_was_overriden = True
78-
return super(CustomRenderer, cls).extract_relationships(
79-
fields, resource, resource_instance
80-
)
78+
return super().extract_relationships(fields, resource, resource_instance)
8179

8280
assert (
8381
CustomRenderer.build_json_resource_obj(

Diff for: example/tests/unit/test_serializer_method_field.py

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
from __future__ import absolute_import
2-
31
from rest_framework import serializers
42

53
from rest_framework_json_api.relations import SerializerMethodResourceRelatedField

Diff for: example/views.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def get_object(self):
5757
if entry_pk is not None:
5858
return Entry.objects.get(id=entry_pk).blog
5959

60-
return super(BlogViewSet, self).get_object()
60+
return super().get_object()
6161

6262

6363
class DRFBlogViewSet(ModelViewSet):
@@ -70,7 +70,7 @@ def get_object(self):
7070
if entry_pk is not None:
7171
return Entry.objects.get(id=entry_pk).blog
7272

73-
return super(DRFBlogViewSet, self).get_object()
73+
return super().get_object()
7474

7575

7676
class JsonApiViewSet(ModelViewSet):
@@ -98,7 +98,7 @@ def handle_exception(self, exc):
9898
exc.status_code = HTTP_422_UNPROCESSABLE_ENTITY
9999
# exception handler can't be set on class so you have to
100100
# override the error response in this method
101-
response = super(JsonApiViewSet, self).handle_exception(exc)
101+
response = super().handle_exception(exc)
102102
context = self.get_exception_handler_context()
103103
return format_drf_errors(response, context, exc)
104104

@@ -121,7 +121,7 @@ def get_object(self):
121121
if entry_pk is not None:
122122
return Entry.objects.exclude(pk=entry_pk).first()
123123

124-
return super(EntryViewSet, self).get_object()
124+
return super().get_object()
125125

126126

127127
class DRFEntryViewSet(ModelViewSet):
@@ -135,7 +135,7 @@ def get_object(self):
135135
if entry_pk is not None:
136136
return Entry.objects.exclude(pk=entry_pk).first()
137137

138-
return super(DRFEntryViewSet, self).get_object()
138+
return super().get_object()
139139

140140

141141
class NoPagination(JsonApiPageNumberPagination):

Diff for: rest_framework_json_api/__init__.py

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
31
__title__ = "djangorestframework-jsonapi"
42
__version__ = "4.2.1"
53
__author__ = ""

Diff for: rest_framework_json_api/django_filters/backends.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def get_schema_operation_parameters(self, view):
138138
139139
This is basically the reverse of `get_filterset_kwargs` above.
140140
"""
141-
result = super(DjangoFilterBackend, self).get_schema_operation_parameters(view)
141+
result = super().get_schema_operation_parameters(view)
142142
for res in result:
143143
if "name" in res:
144144
res["name"] = "filter[{}]".format(res["name"]).replace("__", ".")

Diff for: rest_framework_json_api/filters.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,7 @@ def remove_invalid_fields(self, queryset, fields, view, request):
6161
else:
6262
underscore_fields.append(undo_format_field_name(item_rewritten))
6363

64-
return super(OrderingFilter, self).remove_invalid_fields(
65-
queryset, underscore_fields, view, request
66-
)
64+
return super().remove_invalid_fields(queryset, underscore_fields, view, request)
6765

6866

6967
class QueryParameterValidationFilter(BaseFilterBackend):

Diff for: rest_framework_json_api/parsers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def parse(self, stream, media_type=None, parser_context=None):
7474
"""
7575
Parses the incoming bytestream as JSON and returns the resulting data
7676
"""
77-
result = super(JSONParser, self).parse(
77+
result = super().parse(
7878
stream, media_type=media_type, parser_context=parser_context
7979
)
8080

Diff for: rest_framework_json_api/renderers.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -662,9 +662,7 @@ class BrowsableAPIRenderer(renderers.BrowsableAPIRenderer):
662662
includes_template = "rest_framework_json_api/includes.html"
663663

664664
def get_context(self, data, accepted_media_type, renderer_context):
665-
context = super(BrowsableAPIRenderer, self).get_context(
666-
data, accepted_media_type, renderer_context
667-
)
665+
context = super().get_context(data, accepted_media_type, renderer_context)
668666
view = renderer_context["view"]
669667

670668
context["includes_form"] = self.get_includes_form(view)

Diff for: rest_framework_json_api/serializers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ def get_field_names(self, declared_fields, info):
328328
field = declared_fields[field_name]
329329
if field_name not in meta_fields:
330330
declared[field_name] = field
331-
fields = super(ModelSerializer, self).get_field_names(declared, info)
331+
fields = super().get_field_names(declared, info)
332332
return list(fields) + list(getattr(self.Meta, "meta_fields", list()))
333333

334334

Diff for: setup.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
#!/usr/bin/env python
2-
from __future__ import print_function
1+
#!/usr/bin/env python3
32

43
import os
54
import re

0 commit comments

Comments
 (0)