Skip to content

JSON API 1.1: cursor-pagination profile #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n2ygk opened this issue Jan 7, 2019 · 4 comments
Closed

JSON API 1.1: cursor-pagination profile #548

n2ygk opened this issue Jan 7, 2019 · 4 comments

Comments

@n2ygk
Copy link
Contributor

n2ygk commented Jan 7, 2019

See #547. Analyze new cursor-pagination profile

@sliverc
Copy link
Member

sliverc commented Jan 14, 2019

As far as I understand is this is rather an example and not an actual profile as JSON API is still pagination strategy agonistc.

I think in case of profile the only relevant issue for DJA at this point is #558

@n2ygk
Copy link
Contributor Author

n2ygk commented Jan 14, 2019

See https://github.com/json-api/json-api/blob/gh-pages/_profiles/ethanresnick/cursor-pagination/index.md which looks like cursor pagination is a registered profile.

Profiles adds a new profile media type parameter and query parameter, so at a minimum QueryParameterValidation would need to add this as well?

@sliverc
Copy link
Member

sliverc commented Jan 15, 2019

OK let's leave this issue open then. I seems it duplicates #320 and I guess we should close one of those two? As this is additional profile as I understand it is it not necessarily needed to fully support JSON API 1.1 but rather an addition which an implementation might implement.

I have split up media and query parameter support #560 which will be the base once the first additional profile is implemented.

The profile change in JSON API 1.1 seems to be a fairly big change which we certainly have to have a closer look what it really involves before we implement.

@sliverc
Copy link
Member

sliverc commented Oct 4, 2019

Closing as explained at #547 (comment)

Once JSON API spec is moving forward we need to double check which issue need to be reopened.

@sliverc sliverc closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants