Clarified instructions for opening issues on ancillary repos#43
Closed
adamzap wants to merge 1 commit intodjango:masterfrom
Closed
Clarified instructions for opening issues on ancillary repos#43adamzap wants to merge 1 commit intodjango:masterfrom
adamzap wants to merge 1 commit intodjango:masterfrom
Conversation
Member
There was a problem hiding this comment.
I believe it should be "its", not "it's" here.
Member
|
I need to check with the team if this is the actual policy we have (I remember it differently but it's been a while) but other than that, the PR looks good (well except for the two minor issues I pointed out). Thanks! |
adamzap
force-pushed
the
clarify-ancillary-repo-instructions
branch
from
dbbfd8b to
071979f
Compare
Member
Author
|
Ok, sounds good! I fixed the issues you mentioned. Thanks for the review! |
Member
|
Merged in e0436e0. Thanks! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might help to close #32.
I researched overriding Trac's error template to change the "Create" button's
href, and it seems non-trivial. So it seems like two options available are:hrefon page loadThis patch implements option 2.
Regardless of it's relation to #32, I think this patch is an improvement since it links to both issue trackers.
Before
After