Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to inject any loader into LoadDataFixturesDoctrineCommand #380

Open
oleg-andreyev opened this issue Feb 8, 2023 · 1 comment
Open

Comments

@oleg-andreyev
Copy link

There could be cases when developers needs to inject custom fixture loader into LoadDataFixturesDoctrineCommand, but (un)fortunately SymfonyFixturesLoader is final and cannot be extended to mimic required interface, but at the same time this command is using only \Doctrine\Common\DataFixtures\Loader::getFixtures thus it should be allowed to inject any loader as long as it has getFixtures method.

@stof
Copy link
Member

stof commented Feb 8, 2023

Indeed, I see now reason to typehint the implementation here.

do you want to send a PR to change that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants