Skip to content

Commit 2094f18

Browse files
committed
fix: use .DNSNames instead of .Aliases in tests
Docker has changed their output in an unclear manner, but this is the correct way to check for what dns records are available for usage by apps.
1 parent 705ac54 commit 2094f18

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/link_networks.bats

+4-4
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ teardown() {
4848
assert_output_contains bridge 0
4949
assert_output_contains custom-network
5050

51-
run docker inspect dokku.$PLUGIN_COMMAND_PREFIX.ls -f '{{range $net,$v := .NetworkSettings.Networks}}{{range $k,$alias := $v.Aliases}}{{printf "alias:%s\n" $alias}}{{end}}{{end}}'
51+
run docker inspect dokku.$PLUGIN_COMMAND_PREFIX.ls -f '{{range $net,$v := .NetworkSettings.Networks}}{{range $k,$alias := $v.DNSNames}}{{printf "alias:%s\n" $alias}}{{end}}{{end}}'
5252
echo "output: $output"
5353
echo "status: $status"
5454
assert_success
@@ -120,7 +120,7 @@ teardown() {
120120
assert_output_contains custom-network
121121
assert_output_contains bridge
122122

123-
run docker inspect dokku.$PLUGIN_COMMAND_PREFIX.ls -f '{{range $net,$v := .NetworkSettings.Networks}}{{range $k,$alias := $v.Aliases}}{{printf "alias:%s\n" $alias}}{{end}}{{end}}'
123+
run docker inspect dokku.$PLUGIN_COMMAND_PREFIX.ls -f '{{range $net,$v := .NetworkSettings.Networks}}{{range $k,$alias := $v.DNSNames}}{{printf "alias:%s\n" $alias}}{{end}}{{end}}'
124124
echo "output: $output"
125125
echo "status: $status"
126126
assert_success
@@ -192,7 +192,7 @@ teardown() {
192192
assert_output_contains bridge
193193
assert_output_contains custom-network
194194

195-
run docker inspect dokku.$PLUGIN_COMMAND_PREFIX.ls -f '{{range $net,$v := .NetworkSettings.Networks}}{{range $k,$alias := $v.Aliases}}{{printf "alias:%s\n" $alias}}{{end}}{{end}}'
195+
run docker inspect dokku.$PLUGIN_COMMAND_PREFIX.ls -f '{{range $net,$v := .NetworkSettings.Networks}}{{range $k,$alias := $v.DNSNames}}{{printf "alias:%s\n" $alias}}{{end}}{{end}}'
196196
echo "output: $output"
197197
echo "status: $status"
198198
assert_success
@@ -258,7 +258,7 @@ teardown() {
258258
assert_output_contains bridge
259259
assert_output_contains custom-network
260260

261-
run docker inspect dokku.$PLUGIN_COMMAND_PREFIX.lsa -f '{{range $net,$v := .NetworkSettings.Networks}}{{range $k,$alias := $v.Aliases}}{{printf "alias:%s\n" $alias}}{{end}}{{end}}'
261+
run docker inspect dokku.$PLUGIN_COMMAND_PREFIX.lsa -f '{{range $net,$v := .NetworkSettings.Networks}}{{range $k,$alias := $v.DNSNames}}{{printf "alias:%s\n" $alias}}{{end}}{{end}}'
262262
echo "output: $output"
263263
echo "status: $status"
264264
assert_success

0 commit comments

Comments
 (0)