Project#1
Open
dolphin323 wants to merge 2 commits intoreviewfrom
Open
Conversation
added 2 commits
April 4, 2021 19:52
v1nn1k
suggested changes
Apr 5, 2021
| bottom: 0; | ||
| left: 0; | ||
| margin: auto; | ||
| overflow: hidden; |
| position: absolute; | ||
| } | ||
|
|
||
| @font-face { |
| @@ -0,0 +1,55 @@ | |||
| import { useState } from 'react'; | |||
There was a problem hiding this comment.
import React, {useState} from 'react;
React should be in scope when using JSX
| import './Card.css'; | ||
| import { Data } from "./Data"; | ||
|
|
||
| const Style_of_q = { |
There was a problem hiding this comment.
use camelCase and full names. const questionStyles = {}
| }; | ||
|
|
||
| const Card = () => { | ||
| const [clicked, setClicked] = useState(false) |
There was a problem hiding this comment.
Check out this review
https://github.com/meltaway/dsc-studygroup-react/pull/1#discussion_r606843506
| <div className="all_card"> | ||
| <div className="pictures"> | ||
| <img src="/images/bg-pattern-desktop.svg" className="romb_img" alt="" /> | ||
| <img src="/images/illustration-woman-online-desktop.svg" className="woman_img" alt="" /> |
|
|
||
| <div className="questions"> | ||
| {/* {clicked === index ? <p style={ Style_of_q } : <p>} */} | ||
| <p style={clicked === index ? Style_of_q : null} > |
There was a problem hiding this comment.
Also check out the review above. Create local variable isClicked = clicked === index
| ); | ||
| } | ||
|
|
||
| export default Card No newline at end of file |
olehmell
approved these changes
Apr 6, 2021
Comment on lines
+39
to
+45
| {clicked === index ? ( | ||
| <div className="answers"> | ||
| <p> | ||
| {item.answer} | ||
| </p> | ||
| </div> | ||
| ) : null} |
There was a problem hiding this comment.
- It's better to use
&&instead of?in this case. So{clicked === index && (...)} - Not really good name
clicked. It suppose to be a boolean value but it's comparing with index which is number. I would suggest something likeclickedItemIndex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.