[BUG] Help should be shown but it does not show when you remove G keybinding

[inigosola]

Describe the bug 🐛
Help should be shown but it does not show when you remove G keybinding

To Reproduce 🐣
Steps to reproduce the behavior:

1. Remove G keybinding: api.keys.set("G", api.no_op)
2. Exec dooit
3. Press ?

Expected behavior 🤔
Help should be shown but it does not show.

Desktop): 🤖

• OS: Mac OS
• Version 15.6.1

Additional context 📝

@subscribe(Startup)
def setup(api: DooitAPI, _):
    api.keys.set("j", api.no_op)
    api.keys.set("k", api.no_op)
    api.keys.set("d", api.no_op)
    api.keys.set("r", api.no_op)
    api.keys.set("e", api.no_op)
    api.keys.set("=", api.no_op)
    api.keys.set("+", api.no_op)
    api.keys.set("-", api.no_op)
    api.keys.set("_", api.no_op)
    api.keys.set("i", api.no_op)
    api.keys.set("gg", api.no_op)
    api.keys.set("G", api.no_op)  # comment this line and help is shown when you press `?`
    # api.keys.set("J", api.no_op)
    # api.keys.set("K", api.no_op)
    api.keys.set("xx", api.no_op)
    api.keys.set("<up>", api.move_up, "Mover selector hacia arriba")
    api.keys.set("<down>", api.move_down, "Mover selector hacia abajo")
    api.keys.set("<enter>", api.edit_description, "Editar")
    api.keys.set("<delete>", api.remove_node, "Borrar")
    api.keys.set("<alt+up>", api.shift_up, "Desplazar tarea hacia arriba")
    api.keys.set("<alt+down>", api.shift_down, "Desplazar tarea hacia abajo")

[kraanzu]

Seems to happen even after setting any keybind. interesting
will investigate

[NebelToast]

I am experiencing this same issue on NixOS (unstable channel), but I have found a specific behavior regarding window size that might help identify the cause.

The Issue: When I press ? to open the help menu, the menu does not appear, and the application becomes completely unresponsive to input.

Workaround / Observation: I discovered that the crash is dependent on the window size:

If I resize the terminal window to be small (approx. 1/4 of the screen) before pressing ?, the help menu opens correctly, and the app remains responsive.

However, if I resize the window back up to full size while the help menu is open, the application becomes unresponsive again.

Environment:

OS: NixOS (Unstable)

Terminal: Kitty

Window Manager: Hyprland

[kraanzu]

I'm not sure what happened but looks like a underlying issue in the library, Updated and it works fine. Will merge to main

[NebelToast]

Just tested it with the new commit and it works, i can see the help menu again!
Thanks again for the quick help and the amazing project in general :3

[kraanzu]

Hey @NebelToast
Thank you for the kind words. I've been asking this question around to people
so I'll ask it here as well:

Does the whole python config thing feel weird or over the top? Would it be much better if it were something simple like toml but if you wanted to get into nitty gritty then you could use custom python scripts?

[NebelToast]

So, for some context: Python is the language i am most fluent in. It’s the first one i learned and i appreciate the simplicity.

That being said: For this program I didn't (and have no plans to use) the advantages of a python config file. I find it adds more friction to the config and if someone doesn't know python, it's even more intimidating. So yes(in my opinion) TOML would be better.

Very awesome that you ask for feedback :)