Move key formatting to ValidatableTypeInfo

Author: captainsafia

src/Http/Http.Abstractions/src/Validation/ValidatableTypeInfo.cs

@@ -106,9 +106,17 @@ public virtual async Task ValidateAsync(object? value, ValidateContext context,
                         // Create a validation error for each member name that is provided
                         foreach (var memberName in validationResult.MemberNames)
                         {
+                            // Format the member name using JsonSerializerOptions naming policy if available
+                            // Note: we don't respect [JsonPropertyName] here because we have no context of the property being validated.
+                            var formattedMemberName = memberName;
+                            if (context.SerializerOptions?.PropertyNamingPolicy != null)
+                            {
+                                formattedMemberName = context.SerializerOptions.PropertyNamingPolicy.ConvertName(memberName);
+                            }
+
                             var key = string.IsNullOrEmpty(originalPrefix) ?
-                                memberName :
-                                $"{originalPrefix}.{memberName}";
+                                formattedMemberName :
+                                $"{originalPrefix}.{formattedMemberName}";
                             context.AddOrExtendValidationError(key, validationResult.ErrorMessage);
                         }
 

src/Http/Http.Abstractions/src/Validation/ValidateContext.cs

@@ -14,8 +14,6 @@ namespace Microsoft.AspNetCore.Http.Validation;
 [Experimental("ASP0029", UrlFormat = "https://aka.ms/aspnet/analyzer/{0}")]
 public sealed class ValidateContext
 {
-    private JsonNamingPolicy? _cachedNamingPolicy;
-    private bool _namingPolicyCached;
     /// <summary>
     /// Gets or sets the validation context used for validating objects that implement <see cref="IValidatableObject"/> or have <see cref="ValidationAttribute"/>.
     /// This context provides access to service provider and other validation metadata.
@@ -63,55 +61,33 @@ public sealed class ValidateContext
     /// This is used to prevent stack overflows from circular references.
     /// </summary>
     public int CurrentDepth { get; set; }
-    
+
     /// <summary>
     /// Gets or sets the JSON serializer options to use for property name formatting.
     /// When available, property names in validation errors will be formatted according to the
     /// PropertyNamingPolicy and JsonPropertyName attributes.
     /// </summary>
-    public JsonSerializerOptions? SerializerOptions 
-    { 
+    public JsonSerializerOptions? SerializerOptions
+    {
         get => _serializerOptions;
-        set 
-        { 
-            _serializerOptions = value;
-            // Invalidate cache when SerializerOptions changes
-            _namingPolicyCached = false;
-            _cachedNamingPolicy = null;
-        } 
+        set => _serializerOptions = value;
     }
     private JsonSerializerOptions? _serializerOptions;
 
-    /// <summary>
-    /// Gets the cached naming policy from SerializerOptions to avoid repeated property access.
-    /// </summary>
-    private JsonNamingPolicy? CachedNamingPolicy
-    {
-        get
-        {
-            if (!_namingPolicyCached)
-            {
-                _cachedNamingPolicy = _serializerOptions?.PropertyNamingPolicy;
-                _namingPolicyCached = true;
-            }
-            return _cachedNamingPolicy;
-        }
-    }
-
     internal void AddValidationError(string key, string[] errors)
     {
         ValidationErrors ??= [];
 
-        var formattedKey = FormatKey(key);
+        var formattedKey = key;
         ValidationErrors[formattedKey] = errors;
     }
 
     internal void AddOrExtendValidationErrors(string key, string[] errors)
     {
         ValidationErrors ??= [];
 
-        var formattedKey = FormatKey(key);
-        
+        var formattedKey = key;
+
         if (ValidationErrors.TryGetValue(formattedKey, out var existingErrors))
         {
             var newErrors = new string[existingErrors.Length + errors.Length];
@@ -129,8 +105,8 @@ internal void AddOrExtendValidationError(string key, string error)
     {
         ValidationErrors ??= [];
 
-        var formattedKey = FormatKey(key);
-        
+        var formattedKey = key;
+
         if (ValidationErrors.TryGetValue(formattedKey, out var existingErrors) && !existingErrors.Contains(error))
         {
             ValidationErrors[formattedKey] = [.. existingErrors, error];
@@ -140,94 +116,4 @@ internal void AddOrExtendValidationError(string key, string error)
             ValidationErrors[formattedKey] = [error];
         }
     }
-    
-    private string FormatKey(string key)
-    {
-        var namingPolicy = CachedNamingPolicy;
-        if (string.IsNullOrEmpty(key) || namingPolicy is null)
-        {
-            return key;
-        }
-
-        // If the key contains a path (e.g., "Address.Street" or "Items[0].Name"), 
-        // apply the naming policy to each part of the path
-        if (key.Contains('.') || key.Contains('['))
-        {
-            return FormatComplexKey(key, namingPolicy);
-        }
-
-        // Apply the naming policy directly
-        return namingPolicy.ConvertName(key);
-    }
-    
-    private static string FormatComplexKey(string key, JsonNamingPolicy namingPolicy)
-    {
-        // Use a more direct approach for complex keys with dots and array indices
-        var result = new System.Text.StringBuilder();
-        int lastIndex = 0;
-        int i = 0;
-        bool inBracket = false;
-
-        while (i < key.Length)
-        {
-            char c = key[i];
-            
-            if (c == '[')
-            {
-                // Format the segment before the bracket
-                if (i > lastIndex)
-                {
-                    string segment = key.Substring(lastIndex, i - lastIndex);
-                    string formattedSegment = namingPolicy.ConvertName(segment);
-                    result.Append(formattedSegment);
-                }
-                
-                // Start collecting the bracket part
-                inBracket = true;
-                result.Append(c);
-                lastIndex = i + 1;
-            }
-            else if (c == ']')
-            {
-                // Add the content inside the bracket as-is
-                if (i > lastIndex)
-                {
-                    string segment = key.Substring(lastIndex, i - lastIndex);
-                    result.Append(segment);
-                }
-                result.Append(c);
-                inBracket = false;
-                lastIndex = i + 1;
-            }
-            else if (c == '.' && !inBracket)
-            {
-                // Format the segment before the dot
-                if (i > lastIndex)
-                {
-                    string segment = key.Substring(lastIndex, i - lastIndex);
-                    string formattedSegment = namingPolicy.ConvertName(segment);
-                    result.Append(formattedSegment);
-                }
-                result.Append(c);
-                lastIndex = i + 1;
-            }
-
-            i++;
-        }
-
-        // Format the last segment if there is one
-        if (lastIndex < key.Length)
-        {
-            string segment = key.Substring(lastIndex);
-            if (!inBracket)
-            {
-                segment = namingPolicy.ConvertName(segment);
-            }
-            result.Append(segment);
-        }
-
-        return result.ToString();
-    }
-    
-
 }