-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add multi-targeting sections to trimming and AOT documentation #50076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
sbomer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Add a similar note for IsAotCompatible (alongside the existing docs for that option).
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Added in 78f6612. The note directs users to apply the same multi-targeting guidance when using |
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
|
@copilot fix merge conflicts |
Head branch was pushed to by a user without write access
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
…t#50076) * Initial plan * Add multi-targeting section to trimming documentation Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Update ms.date metadata for document changes Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Simplify multi-targeting section per review feedback Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Clarify multi-targeting recommendation to avoid TFM gaps Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Add multi-targeting note for IsAotCompatible Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Move IsAotCompatible multi-targeting guidance to AOT docs Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Update AOT docs and SDK errors to use net8.0 for AOT, net6.0 for trimming Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Recommend including latest .NET version for latest analyzer Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Use net10.0 as latest .NET version in examples Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add Oxford commas to framework lists Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Break up long sentences for better readability Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Clarify multi-targeting benefits for analyzer support Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Rewrite - Emphasize targeting latest TFM first. - Clarify multi-targeting requirement as separate. - Update heading to match more general guidance * Add Oxford commas and fix grammar per review feedback Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> * Break up long sentences for better readability Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com> Co-authored-by: Sven Boemer <sbomer@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: GitHub Copilot <copilot@github.com>
Adding multi-targeting sections to trimming and AOT documentation
Summary
Per @sbomer's request based on Copilot reviewer feedback:
net6.0/net8.0or later, which is required for trim/AOT analysis warnings" into separate sentences: "At a minimum, targetnet6.0/net8.0or later. This version is required for trim/AOT analysis warnings."Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Internal previews