Skip to content

Matrix.CreateLookAt handedness #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gavin-Williams opened this issue Jul 17, 2019 · 2 comments
Open

Matrix.CreateLookAt handedness #2766

Gavin-Williams opened this issue Jul 17, 2019 · 2 comments
Labels
area-System.Numerics doc-enhancement Improve the current content Pri3 Indicates issues/PRs that are low priority product-feedback Indicates issues that are related to product issues, not docs waiting-on-feedback Indicates PRs that are waiting for feedback from SMEs before they can be merged
Milestone

Comments

@Gavin-Williams
Copy link

Hi,

Matrix4x4.CreateLookAt doesn't indicate which handedness it represents. Since right handedness is the convention, I assume that's what it is. But the method name should indicate what the handedness is for clarity and you should give an option to create the left handed representation as well. And why not use the naming convention of every other Matrix class and call it CreateLookAtRH / CreateLookAtLH ?

As it is, I don't think I can use this method - no source, no indication of it's handedness. I have no choice but to copy code from SharpDX which does respect handedness.

@dotnet-bot dotnet-bot added the untriaged New issue has not been triaged by the area owner label Jul 17, 2019
@mairaw mairaw added waiting-on-feedback Indicates PRs that are waiting for feedback from SMEs before they can be merged doc-enhancement Improve the current content product-feedback Indicates issues that are related to product issues, not docs and removed untriaged New issue has not been triaged by the area owner labels Jul 29, 2019
@mairaw mairaw added this to the Backlog milestone Jul 29, 2019
@mairaw
Copy link
Contributor

mairaw commented Jul 29, 2019

@tannergooding, @ViktorHofer can one of you help with this feedback re. the docs for https://docs.microsoft.com/en-us/dotnet/api/system.numerics.matrix4x4.createlookat and its functionality?

@PRMerger13 PRMerger13 added the Pri3 Indicates issues/PRs that are low priority label Nov 11, 2020
@ghost
Copy link

ghost commented Feb 4, 2022

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Hi,

Matrix4x4.CreateLookAt doesn't indicate which handedness it represents. Since right handedness is the convention, I assume that's what it is. But the method name should indicate what the handedness is for clarity and you should give an option to create the left handed representation as well. And why not use the naming convention of every other Matrix class and call it CreateLookAtRH / CreateLookAtLH ?

As it is, I don't think I can use this method - no source, no indication of it's handedness. I have no choice but to copy code from SharpDX which does respect handedness.

Author: Gavin-Williams
Assignees: -
Labels:

waiting-on-feedback, doc-enhancement, product-feedback, Pri3, area-System.Numerics

Milestone: Backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Numerics doc-enhancement Improve the current content Pri3 Indicates issues/PRs that are low priority product-feedback Indicates issues that are related to product issues, not docs waiting-on-feedback Indicates PRs that are waiting for feedback from SMEs before they can be merged
Projects
None yet
Development

No branches or pull requests

5 participants