-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Essentials Geolocation | Added support for MslAltitudeMeters #27579
base: net10.0
Are you sure you want to change the base?
Conversation
…ion for altitude
Hey there @bricefriha! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should just add a new property? We could even add 2 new properties an be more explicit:
EllipsoidalAltitude
MeanSeaLevelAltitude
Then we obsolete Altitude and keep it returning what it did. Dows Windows have 2 different APIs?
Also saw this:
- https://developer.android.com/reference/android/location/altitude/AltitudeConverter
- https://developer.apple.com/documentation/corelocation/cllocation/ellipsoidalaltitude?language=objc
- https://developer.android.com/reference/kotlin/androidx/core/location/LocationManagerCompat
- https://developer.android.com/reference/kotlin/androidx/core/location/LocationCompat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should target .net10 branch
I agree, but my concern is that we need these for all platforms, which would be a bit redundant for iOS as
thanks, that's interesting; we could play around with that perhaps |
I converted it back to draft so I can make the changes @mattleibow mentioned |
…ltitude implementation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
The goal of this change is to add support for MslAltitudeMeters.
We are setting MslAltitudeMeters as the default value for
Location.Altitude
. If MslAltitude is unavailable or Android version is lower than 34, we just set the regular Altitude.Issues Fixed
Fixes #27554