Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] CollectionView 1's doesn't adjust its offset when resizing a footer #27963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[iOS] CollectionView 1's doesn't adjust its offset when resizing a footer #27963

wants to merge 1 commit into from
+4 −1

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Feb 21, 2025 •
edited
Loading

Description of Change

A small improvement to the mechanism of resizing the header and footer that moves the offset only when the header would be visible. Thanks to it, the CollectionView 1's properly adjust its offset when resizing a footer

Issues Fixed

Fixes #27962

Before After
cv1.mov
fixed.mov

@kubaflo kubaflo requested a review from a team as a code owner February 21, 2025 15:24
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 21, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/iOS 🍎 area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution and removed community ✨ Community Contribution labels Feb 21, 2025
@kubaflo kubaflo changed the title CollectionView 1's footer doesn't resize when changing visibility - fix [iOS] CollectionView 1's doesn't adjust its offset when resizing a footer Feb 21, 2025
@rmarinho
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@samhouts samhouts requested a review from Copilot February 21, 2025 19:20
Copilot
Copilot AI reviewed Feb 21, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@rmarinho
Copy link
Member

Not an issue on CV2 ?

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 22, 2025

Not an issue on CV2 ?

It works but when scrolling up and down after resizing

Screen.Recording.2025-02-22.at.19.30.01.mov

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 22, 2025

Not an issue on CV2 ?

It works but when scrolling up and down after resizing

Screen.Recording.2025-02-22.at.19.30.01.mov

@rmarinho I've tackled the issue with CV2 here #27076 some time ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] CollectionView 1's doesn't adjust its offset when resizing a footer
2 participants
@kubaflo @rmarinho