Skip to content

AsyncRx.NET GroupByUntil can crash when group keys reused #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idg10 opened this issue Apr 30, 2025 · 0 comments · May be fixed by #2201
Open

AsyncRx.NET GroupByUntil can crash when group keys reused #2200

idg10 opened this issue Apr 30, 2025 · 0 comments · May be fixed by #2201
Assignees

Comments

@idg10
Copy link
Collaborator

idg10 commented Apr 30, 2025

Bug

Which library version?

6.0.0-alpha.18

What is the use case or problem?

When the source for GroupByUntil calls OnCompleted, if there are any unexpired groups still active the GroupByUntil operator ends up calling OnCompleted twice, which violates the Rx observer grammar.

This happens because there are two different code paths that call OnCompletedAsync on a group, but only one of them records the fact that has already completed the group, enabling the double call.

What is the expected outcome?

Each group should call OnCompleted exactly once on each observer.

What is the actual outcome?

Some groups call OnCompleted twice on their observers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant