[APX] Make sure KMOV is not encoded in EVEX when JitStressEvexEncoding is set. #113854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
All failures look related to some timeout issue, I presume this is not related to my changes. PR is ready for review. |
This was referenced Mar 25, 2025
Ruihan-Yin
commented
Mar 26, 2025
| { | ||
| // KMOV should not be encoded in EVEX when stressing EVEX, as they are supposed to encded in EVEX only | ||
| // when APX is available, only stressing EVEX is not enough making the encoding valid. | ||
| return false; |
There was a problem hiding this comment.
Or we can return UsePromotedEVEXEncoding() here. Make sure KMOV can be stressed when APX is available.
|
Hi @BruceForstall, please also review this bug fix, thanks! |
|
/azp run runtime-coreclr jitstress-isas-avx512 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Mar 27, 2025
|
/ba-g unrelated azurelinux3 timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #113814
KMOVinstructions will be able to be encoded in EVEX on APX enabled machine to address EGPRs, but on Avx512 machine, they can only be encoded in VEX.we should ensure KMOV has the right prefix under different cases, essentially in the bug, we are stressing original EVEX encoding by
JitStressEvexEncoding. SoKMOVshould not be impacted and stay VEX-encoded.