Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Signing in Repos that Override Build Actions #44855

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Enable Signing in Repos that Override Build Actions #44855

wants to merge 3 commits into from
+7 −0

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Nov 13, 2024 •
edited
Loading

Closes dotnet/source-build#4064

Enables signing for the following repos which were not passing -sign under UB modes:

  • aspnetcore
  • fsharp
  • roslyn

@ellahathaway ellahathaway requested review from a team as code owners November 13, 2024 21:53
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 13, 2024
@ellahathaway
Copy link
Member Author

ellahathaway commented Nov 14, 2024 •
edited
Loading

Looks like the sign arg is not valid in fsharp, but I tested passing /p:Sign=true to fsharp and that worked to invoke signing. Updated in 9ef5b62

@build-analysis build-analysis bot mentioned this pull request Nov 14, 2024
Open
@ellahathaway ellahathaway mentioned this pull request Nov 14, 2024
Open
@ellahathaway
Copy link
Member Author

ellahathaway commented Nov 14, 2024 •
edited
Loading

Signing aspnetcore is failing because there are no ItemsToSign defined in Signing.props: https://github.com/dotnet/aspnetcore/blob/main/eng/Signing.props#L7-L9

Signing aspnetcore artifacts in the VMR needs to be enabled, so I'm continuing this discussion in dotnet/aspnetcore#58445 (comment).

In the meantime, I'm going to draft this PR.

@ellahathaway ellahathaway marked this pull request as draft November 14, 2024 16:25
@ViktorHofer
Copy link
Member

Looks like the sign arg is not valid in fsharp, but I tested passing /p:Sign=true to fsharp and that worked to invoke signing. Updated in 9ef5b62

That's weird. Can you please file an issue in fsharp to track allowing the -sign switch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable signing for arcade repos in the VMR build
2 participants
@ellahathaway @ViktorHofer