Don't cloak the ANCM setup folder #44857
Conversation
|
Failing CI legs are unrelated and failing elsewhere. Merging. |
|
@premun - This change has been merged into the VMR (dotnet/dotnet@56d41c7) but the originally cloaked directory hasn't been added back. It's still excluded in the sources: https://github.com/dotnet/dotnet/tree/main/src/aspnetcore/src/Installers/Windows/AspNetCoreModule-Setup. Why is that? |
|
@mthalman uncloaking does not synchronize it there, manual PR must be opened in the VMR directly with the contents that correspond to the SHA the repository is present in the VMR in |
Is there a tracting issue to support this scenario? |
|
I don't think it was ever planned to be honest - adding exclusion rules also requires removal of the content. We can log an issue but not sure we'd fund it as the exclusions is something we won't have going forward. |
|
Or.. do we want to have exclusions in the full flat VMR codeflow? |
|
We are still going to need/want exclusions going forward IMO. I agree updating them is an uncommon code flow. I guess I am looking for a better UX. Today there is continuous uncertainty on what steps are needed as evidence here. |
|
I will log an issue. We will have a new person starting soon so this looks like a good candidate for an intro issue. |
|
@jkoritzinsky - You'll need to follow the guidance above to make this available in the VMR. |
|
just FYI, @jkoritzinsky is out for a few days |
|
I created dotnet/arcade-services#4152 but during writing it realized it might be quite a problematic one |
See dotnet/sdk#44857 for more details on why this is necessary.
|
Submitted dotnet/dotnet#110. PTAL |
See dotnet/sdk#44857 for more details on why this is necessary. This is copied from the current aspnetcore SHA in the VMR: https://github.com/dotnet/aspnetcore/tree/eb68e016a554b4da50d7fb0aeffe897cfabf36c7/src/Installers/Windows/AspNetCoreModule-Setup
This is required for #44828