-
Notifications
You must be signed in to change notification settings - Fork 315
Spelling #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsoref
wants to merge
35
commits into
dovecot:main
Choose a base branch
from
jsoref:spelling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Spelling #237
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
991addc
spelling: access
jsoref c8afd40
spelling: accidentally
jsoref eb8365a
spelling: address
jsoref 258a877
spelling: after
jsoref dfd3dbf
spelling: backoff
jsoref 6cf2542
spelling: banana
jsoref 82b26a8
spelling: builtin
jsoref 17396e8
spelling: cannot
jsoref 6d1ccb4
spelling: case-sensitive
jsoref 61d2aa4
spelling: client
jsoref fbfa414
spelling: committed
jsoref 74adeb0
spelling: concatenated
jsoref a7f6bee
spelling: connection
jsoref 6715a73
spelling: couldn't
jsoref 8d95556
spelling: digest
jsoref 23b57c4
spelling: dsasl
jsoref 8ebe7d1
spelling: encountered
jsoref c787b56
spelling: filter
jsoref 5a2a356
spelling: for
jsoref ad7f250
spelling: fscked
jsoref 724d7c9
spelling: greater
jsoref 7750df0
spelling: header size
jsoref 89d655d
spelling: hexdigest
jsoref c5eed1f
spelling: hyphen
jsoref bf5969b
spelling: its
jsoref 94bd421
spelling: less
jsoref 34d72bb
spelling: mailbox
jsoref 592aeaa
spelling: nonexistent
jsoref 2128d34
spelling: occurred
jsoref 3a8ec75
spelling: search
jsoref 34eb65d
spelling: spurious
jsoref 983e9fd
spelling: timeout
jsoref 8607ed7
spelling: trailing
jsoref 8df22cf
spelling: unwind
jsoref 357cdce
spelling: with
jsoref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2565,15 +2565,15 @@ dcrypt_openssl_load_public_key_dovecot_v1(struct dcrypt_public_key **key_r, | |
| EVP_PKEY_set1_EC_KEY(key, eckey); | ||
| EC_KEY_free(eckey); | ||
| /* make sure digest matches */ | ||
| buffer_t *dgst = t_buffer_create(32); | ||
| buffer_t *digest = t_buffer_create(32); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This digest and hexdigest seem to be intentional originally, so when we squash the typo fixes into one commit, I think better to keep these two as separate. |
||
| struct dcrypt_public_key tmp; | ||
| i_zero(&tmp); | ||
| tmp.key = key; | ||
| if (!dcrypt_openssl_public_key_id_old(&tmp, dgst, error_r)) { | ||
| if (!dcrypt_openssl_public_key_id_old(&tmp, digest, error_r)) { | ||
| EVP_PKEY_free(key); | ||
| return FALSE; | ||
| } | ||
| if (strcmp(binary_to_hex(dgst->data, dgst->used), | ||
| if (strcmp(binary_to_hex(digest->data, digest->used), | ||
| input[len-1]) != 0) { | ||
| *error_r = "Key id mismatch after load"; | ||
| EVP_PKEY_free(key); | ||
|
|
@@ -2610,15 +2610,15 @@ dcrypt_openssl_load_public_key_dovecot_v2(struct dcrypt_public_key **key_r, | |
| } | ||
|
|
||
| /* make sure digest matches */ | ||
| buffer_t *dgst = t_buffer_create(32); | ||
| buffer_t *digest = t_buffer_create(32); | ||
| struct dcrypt_public_key tmpkey; | ||
| i_zero(&tmpkey); | ||
| tmpkey.key = pkey; | ||
| if (!dcrypt_openssl_public_key_id(&tmpkey, "sha256", dgst, error_r)) { | ||
| if (!dcrypt_openssl_public_key_id(&tmpkey, "sha256", digest, error_r)) { | ||
| EVP_PKEY_free(pkey); | ||
| return FALSE; | ||
| } | ||
| if (strcmp(binary_to_hex(dgst->data, dgst->used), input[len-1]) != 0) { | ||
| if (strcmp(binary_to_hex(digest->data, digest->used), input[len-1]) != 0) { | ||
| *error_r = "Key id mismatch after load"; | ||
| EVP_PKEY_free(pkey); | ||
| return FALSE; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm told this function isn't used yet but will be soon, which means now is the right time to fix its name.