fix(server_family): Remove redundant logging in the CLIENT command (#4859)

BagritsevichStepan · web-flow · commit e5a0a97555fa · 2025-03-31T16:50:10.000+02:00
refactor: address comments

Signed-off-by: Stepan Bagritsevich &lt;stefan@dragonflydb.io&gt;
diff --git a/src/server/server_family.cc b/src/server/server_family.cc
@@ -1999,7 +1999,6 @@ void ServerFamily::Client(CmdArgList args, const CommandContext& cmd_cntx) {
     return ClientHelp(builder);
   }
 
-  LOG_FIRST_N(ERROR, 10) << "Subcommand " << sub_cmd << " not supported";
   return builder->SendError(UnknownSubCmd(sub_cmd, "CLIENT"), kSyntaxErrType);
 }
 
@@ -3252,8 +3251,7 @@ void ServerFamily::Latency(CmdArgList args, const CommandContext& cmd_cntx) {
     return rb->SendEmptyArray();
   }
 
-  LOG_FIRST_N(ERROR, 10) << "Subcommand " << sub_cmd << " not supported";
-  rb->SendError(kSyntaxErr);
+  return rb->SendError(UnknownSubCmd(sub_cmd, "LATENCY"), kSyntaxErrType);
 }
 
 void ServerFamily::ShutdownCmd(CmdArgList args, const CommandContext& cmd_cntx) {

Original file line number	Diff line number	Diff line change
`@@ -1999,7 +1999,6 @@ void ServerFamily::Client(CmdArgList args, const CommandContext& cmd_cntx) {`
`1999`	`1999`	`return ClientHelp(builder);`
`2000`	`2000`	`}`
`2001`	`2001`
`2002`		`- LOG_FIRST_N(ERROR, 10) << "Subcommand " << sub_cmd << " not supported";`
`2003`	`2002`	`return builder->SendError(UnknownSubCmd(sub_cmd, "CLIENT"), kSyntaxErrType);`
`2004`	`2003`	`}`
`2005`	`2004`
`@@ -3252,8 +3251,7 @@ void ServerFamily::Latency(CmdArgList args, const CommandContext& cmd_cntx) {`
`3252`	`3251`	`return rb->SendEmptyArray();`
`3253`	`3252`	`}`
`3254`	`3253`
`3255`		`- LOG_FIRST_N(ERROR, 10) << "Subcommand " << sub_cmd << " not supported";`
`3256`		`- rb->SendError(kSyntaxErr);`
	`3254`	`+ return rb->SendError(UnknownSubCmd(sub_cmd, "LATENCY"), kSyntaxErrType);`
`3257`	`3255`	`}`
`3258`	`3256`
`3259`	`3257`	`void ServerFamily::ShutdownCmd(CmdArgList args, const CommandContext& cmd_cntx) {`