Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Hello, there seems to be a bug in the hyperlink plugin [hyperlink] #4870

Closed
2 tasks done
Itgsvip opened this issue Mar 24, 2025 · 1 comment
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@Itgsvip
Copy link

Itgsvip commented Mar 24, 2025

在您提交此问题之前,您是否检查了以下内容?

  • 这真的是个问题吗?
  • 我已经在 Github Issues 中搜索过了,但没有找到类似的问题。

受影响的包和版本

v0.6.6

复现链接

20250324_172814_20250324_17371592.mp4

复现代码
https://stackblitz.com/edit/univer-sheets-umd-ujtj7qm2?file=index.html

本地样本
demo.zip

如果不使用umd模式,比如在vue中开发,只会触发下面的一种bug:
用户点击编辑单元格后,超链接插件就会一直进入禁用状态,除非用户手动刷新页面。

如果在 umd模式下,才会触正常触发下面的种bug:

  1. 用户点击编辑单元格后,超链接插件就会一直进入禁用状态。
  2. Uncaught TypeError: Cannot read properties of undefined (reading 'SheetDataValidationModel') 异常

我在提交这个bug的时候,录制的视频中,我们可以看到,如果 超链接(hyperlink)UI菜单被禁用后,拖动窗口大小,会重新刷新 超链接(hyperlink)UI 状态,

Image

但是不会刷新 右键的超链接状态。

Image

其实这个bug是我在录制视频才发现的。

预期行为

用户编辑单元格后,超链接插件 是可以正常使用的

实际行为

用户编辑单元格后,超链接插件进入禁用状态,用户无法再操作超链接,比如新增

运行环境

Chrome

系统信息

System:
OS: Windows 10 10.0.19045
CPU: (12) x64 12th Gen Intel(R) Core(TM) i5-12400
Memory: 12.43 GB / 31.78 GB
Binaries:
Node: 18.17.1 - E:\java-dev\node-v18.17.1-win-x64\node.EXE
Yarn: 1.22.22 - E:\java-dev\node-v18.17.1-win-x64\yarn.CMD
npm: 9.6.7 - E:\java-dev\node-v18.17.1-win-x64\npm.CMD
pnpm: 10.6.5 - E:\java-dev\node-v18.17.1-win-x64\pnpm.CMD
Browsers:
Edge: Chromium (121.0.2277.83)
Internet Explorer: 11.0.19041.4355

@univer-bot univer-bot bot added the bug Something isn't working label Mar 24, 2025
@univer-bot
Copy link

univer-bot bot commented Mar 24, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: [Bug] 你好, 超链接插件【hyperlink】似乎出现了一个bug

Title: [Bug] Hello, there seems to be a bug in the hyperlink plugin [hyperlink]


Have you checked the following before you submitted this question?

  • Is this really a problem?
  • I've searched in Github Issues but found no similar questions.

Affected packages and versions

v0.6.6

Reproduce link

20250324_172814_20250324_17371592.mp4

Reproduce the code
https://stackblitz.com/edit/univer-sheets-umd-ujtj7qm2?file=index.html

Local samples
demo.zip

If you do not use the umd mode, such as developing in vue, it will only trigger one of the following bugs:
After the user clicks to edit the cell, the hyperlink plugin will remain disabled unless the user refreshes the page manually.

If it is in umd mode, the following bugs will be triggered normally:

  1. After the user clicks to edit the cell, the hyperlink plug-in will continue to be disabled.
  2. Uncaught TypeError: Cannot read properties of undefined (reading 'SheetDataValidationModel') Exception

When I submitted this bug, in the recorded video, we can see that if the hyperlink UI menu is disabled, drag the window size and the hyperlink UI status will be refreshed.

Image

However, the right-click hyperlink status will not be refreshed.

Image

Actually, I discovered this bug when I was recording a video.

Expected behavior

After the user edits the cell, the hyperlink plugin can be used normally.

Actual behavior

After the user edits the cell, the hyperlink plug-in enters a disabled state, and the user can no longer operate the hyperlink, such as adding a new one.

Running environment

Chrome

System Information

System:
OS: Windows 10 10.0.19045
CPU: (12) x64 12th Gen Intel(R) Core(TM) i5-12400
Memory: 12.43 GB / 31.78 GB
Binaries:
Node: 18.17.1 - E:\java-dev\node-v18.17.1-win-x64\node.EXE
Yarn: 1.22.22 - E:\java-dev\node-v18.17.1-win-x64\yarn.CMD
npm: 9.6.7 - E:\java-dev\node-v18.17.1-win-x64\npm.CMD
pnpm: 10.6.5 - E:\java-dev\node-v18.17.1-win-x64\pnpm.CMD
Browsers:
Edge: Chromium (121.0.2277.83)
Internet Explorer: 11.0.19041.4355

@univer-bot univer-bot bot changed the title [Bug] 你好, 超链接插件【hyperlink】似乎出现了一个bug [Bug] Hello, there seems to be a bug in the hyperlink plugin [hyperlink] Mar 24, 2025
@jikkai jikkai closed this as completed Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants