Fix #6319. Block piping to sql:cli command (#6436)

* Block piping to sql:cli command

* PHPCS

Author: weitzman

src/Commands/sql/SqlCliCommand.php

@@ -4,7 +4,6 @@
 
 namespace Drush\Commands\sql;
 
-use Consolidation\SiteProcess\Util\Tty;
 use Drush\Attributes as CLI;
 use Drush\Boot\DrupalBootLevels;
 use Drush\Command\HelpLinks;
@@ -19,7 +18,6 @@
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\StreamableInputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 #[AsCommand(
@@ -57,6 +55,10 @@ protected function configure(): void
 
     public function execute(InputInterface $input, OutputInterface $output): int
     {
+        if ($this->hasPipedInput()) {
+            throw new RuntimeException('Instead of piping SQL to sql:cli, it is faster to use sql:connect. See the Examples at https://www.drush.org/latest/commands/sql_connect/#examples');
+        }
+
         $sql = SqlBase::create($input->getOptions());
         $program = $sql->command();
         if (!self::programExists($program)) {
@@ -65,19 +67,25 @@ public function execute(InputInterface $input, OutputInterface $output): int
         }
 
         $process = $this->processManager->shell($sql->connect(), null, $sql->getEnv());
-        if (!Tty::isTtySupported()) {
-            $this->logger->warning('It is slow to pass large amounts of data via stdin to the sql:cli command. See the Examples at https://www.drush.org/latest/commands/sql_cli/ for an alternative using sql:connect.');
-            // See https://github.com/symfony/symfony/issues/37835#issuecomment-674386588.
-            // If testing this will get input added by `CommandTester::setInputs` method.
-            $inputStream = ($input instanceof StreamableInputInterface) ? $input->getStream() : null;
-            // If nothing from input stream use STDIN instead.
-            $inputStream = $inputStream ?? STDIN;
-            // $data = stream_get_contents($inputStream);
-            $process->setInput($inputStream);
-        } else {
-            $process->setTty((bool) $this->drushConfig->get('ssh.tty', $input->isInteractive()));
-        }
+        // No longer needed?
+        // if (Tty::isTtySupported()) {
+        //     $process->setTty((bool) $this->drushConfig->get('ssh.tty', $input->isInteractive()));
+        // }
         $process->mustRun($process->showRealtime());
         return Command::SUCCESS;
     }
+
+    /**
+     * Test if there is input waiting on STDIN
+     */
+    protected function hasPipedInput(): bool
+    {
+        $streams = [STDIN]; // note STDIN here is not a string
+        $write_array = [];
+        $except_array = [];
+        $seconds = 0; // zero seconds on timeout since this is just for testing stream change
+        $streamCount = @stream_select($streams, $write_array, $except_array, $seconds);
+
+        return (bool) $streamCount;
+    }
 }

tests/integration/SqlCliTest.php renamed to tests/integration/SqlCommandsTest.php

@@ -9,6 +9,7 @@
 
 namespace Unish;
 
+use Drush\Commands\sql\SqlCliCommand;
 use Drush\Commands\sql\SqlCommands;
 use Drush\Sql\SqlBase;
 use Symfony\Component\Filesystem\Path;
@@ -17,18 +18,21 @@
  * @group commands
  * @group sql
  */
-class SqlCliTest extends UnishIntegrationTestCase
+class SqlCommandsTest extends UnishIntegrationTestCase
 {
-    public function testSqlCli()
+    public function testSqlQuery()
     {
-        if ($this->isWindows()) {
-            $this->markTestSkipped('sql:cli stdin tests do not work on Windows.');
-        }
 
         // @todo Ensure SQL dumps can be imported via sql:cli via stdin.
         $this->drush(SqlCommands::QUERY, [], ['file' => Path::join(__DIR__, 'resources/sqlcli.sql')], self::EXIT_SUCCESS);
         $sql = SqlBase::create();
         $tables = $sql->listTables();
         $this->assertContains('sqlcli', $tables);
     }
+
+    public function testSqlCli()
+    {
+        // @todo Ensure SQL dumps *cannot* be imported via sql:cli via stdin.
+        $this->drush(SqlCliCommand::NAME, [], ['file' => Path::join(__DIR__, 'resources/sqlcli.sql')], self::EXIT_ERROR);
+    }
 }