Allow to disable `error-on-fail` even on CI #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

mahnunchik opened this issue Feb 21, 2025 · 0 comments

mahnunchik commented Feb 21, 2025

It is not possible to override --error-on-fail option on the CI:

patch-package/src/index.ts

Lines 110 to 114 in bd2e9a4

    
           const shouldExitWithError = 
        
             !!argv["error-on-fail"] || 
        
             (process.env.NODE_ENV === "production" && isCI) || 
        
             (isCI && !process.env.PATCH_PACKAGE_INTEGRATION_TEST) || 
        
             process.env.NODE_ENV === "test"

If isCI is true then value of --error-on-fail is ignored.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment