Update for PR fixes

Author: chasewilson

DSCResources/FirefoxPreferenceHelper.psm1

@@ -34,7 +34,7 @@ function Test-FirefoxPreconfiguration
     }
 
     $return = @()
-    if(-not(Test-FirefoxPreference @fileNameParam))
+    if (-not(Test-FirefoxPreference @fileNameParam))
     {
         Write-Verbose -Message 'Firefox "GeneralConfigurationFile" preference not set to Mozilla.cfg'
         $return += 'filename'
@@ -91,20 +91,20 @@ function Test-ConfigStartWithComment
     .SYNOPSIS
         Configures firefox preconfiguration requirements.
 
-    .PARAMETER Preconfigs
+    .PARAMETER Preconfiguration
         Array of which preconfigurations need to be set.
 
     .PARAMETER InstallDirectory
         Directory where FireFox is installed.
 #>
-function Set-FirefoxPreconfigs
+function Set-FirefoxPreconfiguration
 {
     [CmdletBinding()]
     param
     (
         [Parameter(Mandatory = $true)]
         [string[]]
-        $Preconfigs,
+        $Preconfiguration,
 
         [Parameter(Mandatory = $true)]
         [string]
@@ -116,7 +116,7 @@ function Set-FirefoxPreconfigs
         New-Item -Path $autoConfigPath -Type File
     }
 
-    switch ($Preconfigs)
+    switch ($Preconfiguration)
     {
         'filename'
         {
@@ -431,7 +431,7 @@ function Format-FireFoxPreference
 
     switch ($Value)
     {
-        {[bool]::TryParse($Value, [ref]$null) }
+        { [bool]::TryParse($Value, [ref]$null) }
         {
             $result = $Value; break
         }

DSCResources/MSFT_xFirefoxPreference/MSFT_xFirefoxPreference.psm1

@@ -92,13 +92,13 @@ function Set-TargetResource
 
     if (-not(Test-Path -Path $InstallDirectory))
     {
-        throw -Message "$InstallDirectory not found. Verify Firefox is installed and the correct Install Directory is defined."
+        throw "$InstallDirectory not found. Verify Firefox is installed and the correct Install Directory is defined."
     }
 
     $preconfigs = Test-FirefoxPreconfiguration -InstallDirectory $InstallDirectory
     if ($preconfigs)
     {
-        Set-FirefoxPreconfigs -Preconfigs $preconfigs -InstallDirectory $InstallDirectory
+        Set-FirefoxPreconfiguration -Preconfiguration $preconfigs -InstallDirectory $InstallDirectory
     }
 
     if (-not(Test-Path -Path "$InstallDirectory\Mozilla.cfg"))

README.md

@@ -28,10 +28,14 @@ The default is x86.
 
 ### MSFT_xFirefoxPreference
 
-* **PreferenceType**: Specify the type of Preference E.g. lockPref.
+* **PreferenceType**: Specify the type of Preference { Pref | lockPref | defaultPref | unlockPref | clearPref }
+Specifies the preference type of the Firefox Preference to be configured
 * **PreferenceName**: Specify the name of the Preference.
+Specifies the name of the Firefox Preference to be configured
 * **PreferenceValue**: Specify the value of the Preference.
+Specifies value of the Firefox Preference to be configured
 * **InstallDirectory**: Specifies the location where Mozilla Firefox is installed.
+Specifies the directory where Firefox is installed
 
 ## Versions