refactor(workflow): fix github action CI warnings

Author: wooln

src/Dtmworkflow/Workflow.Imp.cs

@@ -193,7 +193,7 @@ private StepResult StepResultFromGrpc(IMessage reply, Exception err)
             return sr;
         }
 
-        public HttpResponseMessage StepResultToHttp(StepResult r)
+        internal HttpResponseMessage StepResultToHttp(StepResult r)
         {
             if (r.Error != null)
             {
@@ -203,7 +203,7 @@ public HttpResponseMessage StepResultToHttp(StepResult r)
             return Utils.NewJSONResponse(HttpStatusCode.OK, r.Data);
         }
 
-        public StepResult StepResultFromHTTP(HttpResponseMessage resp, Exception err)
+        internal StepResult StepResultFromHTTP(HttpResponseMessage resp, Exception err)
         {
             var sr = new StepResult
             {
@@ -234,7 +234,7 @@ private string WfErrorToStatus(Exception err)
         }
 
 
-        public async Task<StepResult> RecordedDo(Func<DtmCommon.BranchBarrier, Task<StepResult>> fn)
+        internal async Task<StepResult> RecordedDo(Func<DtmCommon.BranchBarrier, Task<StepResult>> fn)
         {
             StepResult sr = await this.RecordedDoInner(fn);
 

src/Dtmworkflow/Workflow.cs

@@ -34,13 +34,8 @@ public Workflow(IDtmClient httpClient, IDtmgRPCClient grpcClient, Dtmcli.IBranch
 
         public System.Net.Http.HttpClient NewRequest()
         {
-            if(true)
-                return new HttpClient(new WorkflowHttpInterceptor(this));
-            else
-            {
-                var client =  _httpClient.GetHttpClient("WF");
-                return client;
-            }
+            // return _httpClient.GetHttpClient("WF");
+            return new HttpClient(new WorkflowHttpInterceptor(this));
         }
 
         /// <summary>

tests/Dtmgrpc.IntegrationTests/WorkflowGrpcTest.cs

@@ -85,9 +85,10 @@ public async Task Execute_DoAndHttp_ShouldSuccess()
                 workflow.NewBranch().OnRollback(async (barrier) =>
                 {
                     _testOutputHelper.WriteLine("1. local rollback");
+                    await Task.CompletedTask;
                 }).Do(async (barrier) =>
                 {
-                    return ("my result"u8.ToArray(), null);
+                    return await Task.FromResult<(byte[], Exception)>(("my result"u8.ToArray(), null));
                 });
 
                 // 2. http1, SAGA
@@ -101,7 +102,6 @@ public async Task Execute_DoAndHttp_ShouldSuccess()
                 HttpResponseMessage httpResult2 =  await workflow.NewBranch().OnRollback(async (barrier) =>
                 {
                     _testOutputHelper.WriteLine("4. http2 cancel");
-                   
                     await workflow.NewRequest().GetAsync("http://localhost:5006/test-http-ok1");
                 }).OnCommit(async (barrier) =>
                 {
@@ -176,21 +176,24 @@ public async Task Execute_DoAndHttp_Failed()
                 workflow.NewBranch().OnRollback(async (barrier) =>
                 {
                     _testOutputHelper.WriteLine("1. local rollback");
+                    await Task.CompletedTask;
                 }).Do(async (barrier) =>
                 {
-                    return ("my result"u8.ToArray(), null);
+                    return await Task.FromResult<(byte[], Exception)>(("my result"u8.ToArray(), null));
                 });
 
                 // 2. http1
                 HttpResponseMessage httpResult1 =  await workflow.NewBranch().OnRollback(async (barrier) =>
                 {
                     _testOutputHelper.WriteLine("4. http1 rollback");
+                    await Task.CompletedTask;
                 }).NewRequest().GetAsync("http://localhost:5006/test-http-ok1");
 
                 // 3. http2
                 HttpResponseMessage httpResult2 =  await workflow.NewBranch().OnRollback(async (barrier) =>
                 {
                     _testOutputHelper.WriteLine("4. http2 rollback");
+                    await Task.CompletedTask;
                 }).NewRequest().GetAsync("http://localhost:5006/409"); // 409
 
                 return await Task.FromResult("my result"u8.ToArray());