Skip to content

Commit 9e9bff8

Browse files
committed
Add JPMS automatic module name (1.4)
This is a backport of the PR #454 to `v1.4-andium` stable branch. This PR adds the name `duckdb.jdbc` as an [automatic JPMS module](https://openjdk.org/projects/jigsaw/spec/sotms/#automatic-modules) name to the driver JAR. This makes this name, that was previously derived from the JAR file name, to be stable when the driver is used from modular applications. Testing: CI test added that checks the module name. Fixes: #431
1 parent a7ce5de commit 9e9bff8

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

.github/workflows/Java.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,12 @@ jobs:
7777
run: |
7878
nm -gU ./build/release/libduckdb_java.so_linux_amd64
7979
80+
- name: Check Module Name
81+
run: |
82+
java \
83+
--module-path ./build/release/duckdb_jdbc.jar \
84+
-d duckdb.jdbc
85+
8086
- name: JDBC Tests EL8
8187
if: ${{ inputs.skip_tests != 'true' }}
8288
run: |

META-INF/MANIFEST.MF

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ Bundle-ContactAddress: [email protected]
1111
Bundle-Copyright: Copyright (c) DuckDB Labs
1212
Export-Package: org.duckdb, org.duckdb.io, org.duckdb.user
1313
Import-Package: javax.sql, org.osgi.framework;resolution:=optional
14+
Automatic-Module-Name: duckdb.jdbc

0 commit comments

Comments
 (0)