add some tests for basic types

Author: HuyNguyen7994

src/include/postgres_text_reader.hpp

@@ -9,11 +9,13 @@
 #pragma once
 
 #include "duckdb.hpp"
+#include "duckdb/common/exception.hpp"
 #include "duckdb/common/types.hpp"
 #include "duckdb/common/types/vector.hpp"
 #include "libpq-fe.h"
 #include "postgres_conversion.hpp"
 #include "postgres_connection.hpp"
+#include "postgres_utils.hpp"
 #include <cstring>
 
 namespace duckdb {
@@ -45,21 +47,45 @@ struct PostgresTextReader {
 		}
 	}
 
-	void ReadColumn(idx_t col_idx) {
+	void ReadColumn(const PostgresType &pg_type, idx_t col_idx) {
 		col_vec.Resize(0, RowCount());
+		col_vec.Initialize(true);
 		for (idx_t row_idx = 0; row_idx < RowCount(); row_idx++) {
 			if (PQgetisnull(result, row_idx, col_idx)) {
 				FlatVector::SetNull(col_vec, row_idx, true);
 				continue;
 			}
 			char *value = PQgetvalue(result, row_idx, col_idx);
 			int value_len = PQgetlength(result, row_idx, col_idx);
-			FlatVector::GetData<string_t>(col_vec)[row_idx] = StringVector::AddStringOrBlob(col_vec, value, value_len);
+			FlatVector::SetNull(col_vec, row_idx, false);
+			switch (pg_type.info) {
+				case PostgresTypeAnnotation::FIXED_LENGTH_CHAR: {
+					// CHAR column - remove trailing spaces
+					while (value_len > 0 && value[value_len - 1] == ' ') {
+						value_len--;
+					}
+					FlatVector::GetData<string_t>(col_vec)[row_idx] = StringVector::AddStringOrBlob(col_vec, value, value_len);
+					break;
+				}
+
+				default: 
+					FlatVector::GetData<string_t>(col_vec)[row_idx] = StringVector::AddStringOrBlob(col_vec, value, value_len);
+					break;
+			} 
+
 		}
 	}
 
-	void LoadResultTo (idx_t &col_idx, Vector &out_vec) {
-		ReadColumn(col_idx);
+	void LoadResultTo (const LogicalType &type, const PostgresType &pg_type, Vector &out_vec, idx_t &col_idx) {
+		switch (type.id()) {
+			case LogicalTypeId::LIST:
+			case LogicalTypeId::ENUM:
+				throw NotImplementedException("Type %s doesn't support straight casting from string", type.ToString());
+
+			default:
+				break;
+		}
+		ReadColumn(pg_type, col_idx);
 		VectorOperations::DefaultCast(col_vec, out_vec, RowCount());
 	}
 

src/postgres_extension.cpp

@@ -182,7 +182,7 @@ static void LoadInternal(DatabaseInstance &db) {
 	config.AddExtensionOption("pg_debug_show_queries", "DEBUG SETTING: print all queries sent to Postgres to stdout",
 	                          LogicalType::BOOLEAN, Value::BOOLEAN(false), SetPostgresDebugQueryPrint);
 	config.AddExtensionOption("pg_use_legacy_text_protocol", "Whether or not to use legacy TEXT protocol to read data. Set this to yes will ignore pg_use_binary_copy",
-	                          LogicalType::BOOLEAN, Value::BOOLEAN(true));
+	                          LogicalType::BOOLEAN, Value::BOOLEAN(false));
 
 	OptimizerExtension postgres_optimizer;
 	postgres_optimizer.optimize_function = PostgresOptimizer::Optimize;

src/postgres_scanner.cpp

@@ -1,7 +1,9 @@
 #include "duckdb.hpp"
 
+#include <csignal>
 #include <libpq-fe.h>
 
+#include "duckdb/common/exception.hpp"
 #include "duckdb/common/unique_ptr.hpp"
 #include "duckdb/main/extension_util.hpp"
 #include "duckdb/common/shared_ptr.hpp"
@@ -505,7 +507,13 @@ void PostgresLocalState::ScanChunkWithTextReader(ClientContext &context, const P
 	for (idx_t output_idx = 0; output_idx < output.ColumnCount(); output_idx++) {
 		auto col_idx = column_ids[output_idx];
 		auto &out_vec = output.data[output_idx];
-		reader.LoadResultTo(col_idx, out_vec);
+		if (col_idx == COLUMN_IDENTIFIER_ROW_ID) {
+			PostgresType ctid_type;
+			ctid_type.info = PostgresTypeAnnotation::CTID;
+			reader.LoadResultTo(LogicalType::BIGINT, ctid_type, out_vec, col_idx);
+		} else {
+			reader.LoadResultTo(bind_data.types[col_idx], bind_data.postgres_types[col_idx], out_vec, col_idx);
+		}
 	}
 	reader.Reset();
 	done = true;