Skip to content

Commit 6ccd0ed

Browse files
committed
Disable by default and add test
1 parent cbd19e2 commit 6ccd0ed

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/postgres_extension.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ static void LoadInternal(DatabaseInstance &db) {
183183
config.AddExtensionOption("pg_use_text_protocol",
184184
"Whether or not to use TEXT protocol to read data. This is slower, but provides better "
185185
"compatibility with non-Postgres systems",
186-
LogicalType::BOOLEAN, Value::BOOLEAN(true));
186+
LogicalType::BOOLEAN, Value::BOOLEAN(false));
187187

188188
OptimizerExtension postgres_optimizer;
189189
postgres_optimizer.optimize_function = PostgresOptimizer::Optimize;

test/sql/storage/attach_types.test

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,3 +82,14 @@ SELECT ANY_VALUE(${column_name})=getvariable('minimum_value') FROM s.all_types W
8282
true
8383

8484
endloop
85+
86+
# text protocol
87+
statement ok
88+
SET pg_use_text_protocol=true;
89+
90+
query IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIII
91+
SELECT COLUMNS(*)::VARCHAR FROM s.all_types
92+
----
93+
false -128 -32768 -2147483648 -9223372036854775808 0 0 0 2000-01-01 00:00:00 2000-01-01 01:02:03 2000-01-01 01:02:03 2000-01-01 01:02:03 2000-01-01 01:02:03 00:00:00+15:00 2000-01-01 01:02:03 -999.9 -99999.9999 -999999999999.999999 -9999999999999999999999999999.9999999999 00000000-0000-0000-0000-000000000000 00:00:00 🦆🦆🦆🦆🦆🦆 thisisalongblob\x00withnullbytes 0010001001011100010101011010111 DUCK_DUCK_ENUM enum_0 enum_0 [] [] [] [] [] [🦆🦆🦆🦆🦆🦆, goose, NULL]
94+
true 127 32767 2147483647 9223372036854775807 255 65535 4294967295 2000-01-01 24:00:00 2000-01-01 01:02:03 2000-01-01 01:02:03 2000-01-01 01:02:03 2000-01-01 01:02:03 00:00:00+15:00 2000-01-01 01:02:03 999.9 99999.9999 999999999999.999999 9999999999999999999999999999.9999999999 ffffffff-ffff-ffff-ffff-ffffffffffff 83 years 3 months 999 days 00:16:39.999999 goo se \x00\x00\x00a 10101 GOOSE enum_299 enum_69999 [42, 999, NULL, NULL, -42] [42.0, nan, inf, -inf, NULL, -42.0] [1970-01-01, infinity, -infinity, NULL, 2022-05-12] ['1970-01-01 00:00:00', infinity, -infinity, NULL, '2022-05-12 16:23:45'] ['1970-01-01 00:00:00+00', infinity, -infinity, NULL, '2022-05-12 23:23:45+00'] [🦆🦆🦆🦆🦆🦆, goose, NULL]
95+
NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL

0 commit comments

Comments
 (0)