Update dependencies and add test to make sure package.json and bower.json versions are in sync.

Author: dalelotts

.jscsrc

@@ -1,7 +1,8 @@
 {
-  "preset": "crockford",
   "disallowDanglingUnderscores": { "allExcept": ["_$compile_", "_$rootScope_"] },
   "disallowMultipleVarDecl": "strict",
-  "validateIndentation": 2,
-  "requireMultipleVarDecl": null
-}
+  "preset": "crockford",
+  "requireMultipleVarDecl": null,
+  "requireVarDeclFirst": null,
+  "validateIndentation": 2
+}

README.md

@@ -14,27 +14,6 @@ Native AngularJS datetime picker directive styled by Twitter Bootstrap 3
 
 [Home / demo page](http://dalelotts.github.io/angular-bootstrap-datetimepicker/)
 
-# Upgrading to 0.3.x
-
-<code>weekStart</code> has been removed. This directive uses the locale aware 
-[moment.js day of week](http://momentjs.com/docs/#/get-set/weekday/) to
-determine which day is the first day of the week. If you would like a first 
-day of week that is not standard for the locale you can create a 
-[custom locale](http://momentjs.com/docs/#/customization/) 
-
-## Easier to control width
-
-The width of the entire control is set in css, which you can easily override.
-
-## Better localization support
-
-This directive uses localized date formats when available. One exception is the title
-of the month view - moment does not (yet) have a localized format for month and year.
-
-# (Almost) Complete re-write
-
-This project started as an AngularJS specific re-write of the [bootstrap-datetimepicker project](https://github.com/smalot/bootstrap-datetimepicker).
-Only the CSS file from the bootstrap-datetimepicker project was re-used.
 
 #Dependencies
 
@@ -47,6 +26,8 @@ optional:
  * bootstrap's dropdown component (`dropdowns.less`)
 
 #Testing
+This directive was written using TDD and all enhancements and changes have related tests.
+
 We use karma and jshint to ensure the quality of the code. The easiest way to run these checks is to use gulp:
 
 ```
@@ -164,6 +145,12 @@ data-on-set-time="onTimeSet"    <-- **This will NOT work, the ()'s are required*
 
 
 ## Configuration Options
+***NOTE*** The configuration optionss are not attributes on the element but rather members of the configuration object,
+which is specified in the data-datetimepicker-config attribute.
+
+```html
+<datetimepicker data-ng-model="data.date" data-datetimepicker-config="{ dropdownSelector: '.dropdown-toggle' }"></datetimepicker>
+```
 
 ### startView
 
@@ -262,11 +249,19 @@ In this example, the drop-down functionality is controlled by Twitter Bootstrap.
 The <code>dropdownSelector</code> tells the datetimepicker which element is bound to the Twitter Bootstrap drop-down so
 the drop-down is toggled closed after the user selectes a date/time.
 
-## I18N
+
+## I18N / l10n support
 
 All internationalization is handled by Moment.js, see Moment's documentation for details.
 In most cases, all that is needed is a call to ```moment.locale(String)```
 
+One exception is the title of the month view - moment does not (yet) have a localized format for month and year.
+
+```JavaScript
+moment.locale('en');        // English
+moment.locale('zh-cn');     // Simplified chinese
+```
+
 # Screenshots
 
 ## Year view
@@ -305,6 +300,9 @@ This view allows the user to select a specific time of day, in the selected hour
 By default, the time is displayed in 5 minute increments. The <code>minuteStep</code> property controls the increments of time displayed.
 If the minute view is the minView, which is is by default, the date will be set to the beginning of the hour on the day selected.
 
+##Contributing
+
+
 ## License
 
 angular-bootstrap-datetimepicker is freely distributable under the terms of the [MIT license](LICENSE).

bower.json

@@ -23,8 +23,8 @@
     "test*"
   ],
   "dependencies": {
-    "angular": "~1.3.14",
-    "moment": "^2.9.0"
+    "angular": "^1.4.4",
+    "moment": "^2.10.6"
   },
   "devDependencies": {
     "angular-mocks": "~1.3.14",

gulpfile.js

@@ -5,7 +5,7 @@
 var gulp = require('gulp');
 var jscs = require('gulp-jscs');
 var jshint = require('gulp-jshint');
-var karma = require('karma').server;
+var Server = require('karma').Server;
 var karmaConfig = __dirname + '/karma.conf.js';
 var lodash = require('lodash');
 var paths = require('./paths');
@@ -31,21 +31,33 @@ var testConfig = function (options) {
 };
 
 gulp.task('test', function (done) {
-  karma.start(testConfig(
+
+  var config = testConfig(
     {
       configFile: karmaConfig,
       singleRun: true,
       reporters: ['progress', 'coverage', 'threshold']
     }
-  ), done);
+  );
+
+  var server = new Server(config, done);
+  server.start();
 });
 
 gulp.task('tdd', function (done) {
   gulp.watch(paths.all, ['lint']);
 
-  karma.start({
-    configFile: karmaConfig
-  }, done);
+  var config = testConfig(
+    {
+      autoWatch: true,
+      browsers: ['PhantomJS'],
+      configFile: karmaConfig,
+      singleRun: false
+    }
+  );
+
+  var server = new Server(config, done);
+  server.start();
 });
 
 gulp.task('lint', function () {

package.json

@@ -10,31 +10,31 @@
   "homepage": "http://dalelotts.github.io/angular-bootstrap-datetimepicker",
   "main": "src/js/datetimepicker.js",
   "dependencies": {
-    "angular": "^1.3.16",
-    "bower": "latest",
-    "moment": "^2.10.3"
+    "angular": "^1.4.4",
+    "moment": "^2.10.6"
   },
   "devDependencies": {
+    "bower": "latest",
     "grunt": "^0.4.4",
-    "grunt-bump": "^0.3.0",
+    "grunt-bump": "^0.3.2",
     "gulp": "^3.8.11",
-    "gulp-jscs": "^1.4.0",
-    "gulp-jshint": "^1.9.4",
+    "gulp-jscs": "^2.0.0",
+    "gulp-jshint": "^1.11.2",
     "jshint": "^2.6.0",
     "jshint-stylish": "^2.0.1",
-    "karma": "^0.12.31",
-    "karma-chrome-launcher": "^0.1.5",
-    "karma-coverage": "^0.4.2",
+    "karma": "^0.13.9",
+    "karma-chrome-launcher": "^0.2.0",
+    "karma-coverage": "^0.5.0",
     "karma-firefox-launcher": "^0.1.3",
-    "karma-jasmine": "^0.3.2",
-    "karma-phantomjs-launcher": "^0.2.0",
+    "karma-jasmine": "^0.3.6",
+    "karma-phantomjs-launcher": "^0.2.1",
     "karma-threshold-reporter": "^0.1.12",
-    "lodash": "^3.5.0",
+    "lodash": "^3.10.1",
     "matchdep": "^0.3.0",
-    "phantomjs": "^1.9.12",
+    "phantomjs": "^1.9.18",
     "plato": "^1.5.0",
     "run-browser": "^2.0.2",
-    "tape": "^4.0.0"
+    "tape": "^4.2.0"
   },
   "scripts": {
     "test": "npm run test-browserify && gulp",

test/commonjs/browserify.test.js

@@ -22,3 +22,15 @@ tapeTest('can load module after requiring', function (t) {
   t.doesNotThrow(loadModule);
   t.end();
 });
+
+tapeTest('package and bower dependencies & version match', function (t) {
+  'use strict';
+
+  var packageFile = require('../../package.json');
+  var bowerFile = require('../../bower.json');
+
+  t.equal(packageFile.version, bowerFile.version, 'Version mismatch');
+  t.equal(packageFile.dependencies.angular, bowerFile.dependencies.angular, 'Angular mismatch');
+  t.equal(packageFile.dependencies.moment, bowerFile.dependencies.moment, 'moment mismatch');
+  t.end();
+});