Inspection related changes.

Author: dalelotts

Diff for: README.md

@@ -264,7 +264,8 @@ the drop-down is toggled closed after the user selectes a date/time.
 
 ## I18N
 
-All internationalization is handled by Moment.js, see Moment's documention for details.
+All internationalization is handled by Moment.js, see Moment's documentation for details.
+In most cases, all that is needed is a call to ```moment.locale(String)```
 
 # Screenshots
 

Diff for: contributing.md

@@ -14,19 +14,21 @@ cd angular-bootstrap-datetimepicker
 npm install -g grunt-cli
 npm install
 git checkout develop  # all patches against develop branch, please!
-grunt                 # this runs tests and jshint
+gulp                  # this runs jscs, jshint, complexity checks, and unit tests.
 ```
 
 Very important notes
 ====================
 
  * **Pull pull requests to the `master` branch will be closed.** Please submit all pull requests to the `develop` branch.
  * **Pull requests will not be merged without unit tests.** 
- * **Do not include the minified files in your pull request.** 
+ * **Do not include the minified files in your pull request.**
+ * **Have good tests. If you don't have tests for very line and branch in your changes, I won't accept the PR.
+ * **If your PR fails the CI build, I won't look at it.
 
-Grunt tasks
+Gulp tasks
 ===========
 
-We use Grunt for managing the build. Here are some useful Grunt tasks:
+We use Gulp for managing the build. Here are some useful Gulp tasks:
 
-  * `grunt` The default task lints the code and runs the tests. You should make sure you do this before submitting a PR.
+  * `gulp` The default task checks the coding style, lints the code, calculates complexity, runs the tests, and enforces code coverage. You should make sure you do this before submitting a PR.

Diff for: demo/demo-controller.js

@@ -1,9 +1,10 @@
-/*globals angular, moment, $, console*/
+/*globals angular, moment, $ */
 
 angular.module('demo.demoController', [])
   .controller('demoController', [
     '$scope',
-    function ($scope) {
+    '$log',
+    function ($scope, $log) {
       'use strict';
       $scope.controllerName = 'demoController';
 
@@ -32,7 +33,7 @@ angular.module('demo.demoController', [])
         // However, can write this function to take any
         // action necessary once the user has selected a
         // date/time using the picker
-        console.log(newDate);
+        $log.info(newDate);
         $('#dropdown3').dropdown('toggle');
       };
 
@@ -46,16 +47,16 @@ angular.module('demo.demoController', [])
 
 
       $scope.guardianOnSetTime = function ($index, guardian, newDate, oldDate) {
-        console.log($index);
-        console.log(guardian.name);
-        console.log(newDate);
-        console.log(oldDate);
+        $log.info($index);
+        $log.info(guardian.name);
+        $log.info(newDate);
+        $log.info(oldDate);
         angular.element('#guardian' + $index).dropdown('toggle');
       };
 
       $scope.beforeRender = function ($dates) {
         var index = Math.floor(Math.random() * $dates.length);
-        console.log(index);
+        $log.info(index);
         $dates[index].selectable = false;
       };
 

Diff for: demo/favicons/android-chrome-144x144.png

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8"?>
+<browserconfig>
+  <msapplication>
+    <tile>
+      <square70x70logo src="/demo/favicons/mstile-70x70.png"/>
+      <square150x150logo src="/demo/favicons/mstile-150x150.png"/>
+      <square310x310logo src="/demo/favicons/mstile-310x310.png"/>
+      <wide310x150logo src="/demo/favicons/mstile-310x150.png"/>
+      <TileColor>#da532c</TileColor>
+    </tile>
+  </msapplication>
+</browserconfig>

Diff for: demo/favicons/android-chrome-192x192.png

@@ -0,0 +1,41 @@
+{
+	"name": "Angular Bootstrap Datetime picker",
+	"icons": [
+		{
+			"src": "\/android-chrome-36x36.png",
+			"sizes": "36x36",
+			"type": "image\/png",
+			"density": "0.75"
+		},
+		{
+			"src": "\/android-chrome-48x48.png",
+			"sizes": "48x48",
+			"type": "image\/png",
+			"density": "1.0"
+		},
+		{
+			"src": "\/android-chrome-72x72.png",
+			"sizes": "72x72",
+			"type": "image\/png",
+			"density": "1.5"
+		},
+		{
+			"src": "\/android-chrome-96x96.png",
+			"sizes": "96x96",
+			"type": "image\/png",
+			"density": "2.0"
+		},
+		{
+			"src": "\/android-chrome-144x144.png",
+			"sizes": "144x144",
+			"type": "image\/png",
+			"density": "3.0"
+		},
+		{
+			"src": "\/android-chrome-192x192.png",
+			"sizes": "192x192",
+			"type": "image\/png",
+			"density": "4.0"
+		}
+	]
+}

Diff for: demo/favicons/android-chrome-36x36.png

@@ -12,6 +12,25 @@
     <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
     <title>Angular Bootstrap - Date Time Picker Demo</title>
     <base href="..">
+
+    <link rel="apple-touch-icon" sizes="57x57" href="/demo/favicons/apple-touch-icon-57x57.png">
+    <link rel="apple-touch-icon" sizes="60x60" href="/demo/favicons/apple-touch-icon-60x60.png">
+    <link rel="apple-touch-icon" sizes="72x72" href="/demo/favicons/apple-touch-icon-72x72.png">
+    <link rel="apple-touch-icon" sizes="76x76" href="/demo/favicons/apple-touch-icon-76x76.png">
+    <link rel="apple-touch-icon" sizes="114x114" href="/demo/favicons/apple-touch-icon-114x114.png">
+    <link rel="apple-touch-icon" sizes="120x120" href="/demo/favicons/apple-touch-icon-120x120.png">
+    <link rel="apple-touch-icon" sizes="144x144" href="/demo/favicons/apple-touch-icon-144x144.png">
+    <link rel="apple-touch-icon" sizes="152x152" href="/demo/favicons/apple-touch-icon-152x152.png">
+    <link rel="apple-touch-icon" sizes="180x180" href="/demo/favicons/apple-touch-icon-180x180.png">
+    <link rel="icon" type="image/png" href="/demo/favicons/favicon-32x32.png" sizes="32x32">
+    <link rel="icon" type="image/png" href="/demo/favicons/android-chrome-192x192.png" sizes="192x192">
+    <link rel="icon" type="image/png" href="/demo/favicons/favicon-96x96.png" sizes="96x96">
+    <link rel="icon" type="image/png" href="/demo/favicons/favicon-16x16.png" sizes="16x16">
+    <link rel="manifest" href="/demo/favicons/manifest.json">
+    <meta name="msapplication-TileColor" content="#da532c">
+    <meta name="msapplication-TileImage" content="/mstile-144x144.png">
+    <meta name="theme-color" content="#ffffff">
+
     <link rel="stylesheet" href="bower_components/bootstrap/dist/css/bootstrap.css">
     <link rel="stylesheet" href="src/css/datetimepicker.css">
     <script type="text/javascript" src="bower_components/jquery/dist/jquery.js"></script>

Diff for: demo/favicons/android-chrome-48x48.png

@@ -9,11 +9,15 @@ var karma = require('karma').server;
 var karmaConfig = __dirname + '/karma.conf.js';
 var lodash = require('lodash');
 var paths = require('./paths');
-var plato = require('gulp-plato');
+var plato = require('plato');
 
-gulp.task('complexity', function () {
-  return gulp.src('src/**/*.js')
-    .pipe(plato('complexity'));
+gulp.task('complexity', function (done) {
+
+  var callback = function () {
+    done();
+  };
+
+  plato.inspect(paths.lint, 'complexity', {title: 'prerender', recurse: true}, callback);
 });
 
 var testConfig = function (options) {

Diff for: demo/favicons/android-chrome-72x72.png

@@ -20,7 +20,6 @@
     "gulp": "^3.8.11",
     "gulp-jscs": "^1.4.0",
     "gulp-jshint": "^1.9.4",
-    "gulp-plato": "^1.0.2",
     "jshint": "^2.6.0",
     "jshint-stylish": "^1.0.1",
     "karma": "^0.12.31",
@@ -33,6 +32,7 @@
     "lodash": "^3.5.0",
     "matchdep": "^0.3.0",
     "phantomjs": "^1.9.12",
+    "plato": "^1.5.0",
     "run-browser": "^2.0.2",
     "tape": "^3.5.0"
   },

Diff for: demo/favicons/android-chrome-96x96.png

@@ -8,15 +8,17 @@ var bower = [
   'bower_components/angular/angular.js',
   'bower_components/angular-mocks/angular-mocks.js'
 ];
+var bumpFiles = ['package.json', 'bower.json', 'README.md', 'src/js/*.js', 'src/css/*.css'];
+var miscFiles = ['GruntFile.js', 'gulpfile.js', 'karma.conf.js', 'paths.js'];
+var demoFiles = ['demo/**/*.js'];
 var sourceFiles = ['src/**/*.js'];
 var testFiles = ['test/**/*.spec.js'];
-var miscFiles = ['demo/**/*.js'];
-var bumpFiles = ['package.json', 'bower.json', 'README.md', 'src/js/*.js', 'src/css/*.css'];
 
 module.exports = {
-  all: bower.concat(sourceFiles).concat(testFiles).concat(miscFiles),
+  all: bower.concat(sourceFiles).concat(testFiles).concat(demoFiles),
   app: sourceFiles,
   bump: bumpFiles,
-  lint: ['GruntFile.js', 'gulpfile.js', 'karma.conf.js', 'paths.js', 'test/**/*.test.js'].concat(sourceFiles).concat(testFiles).concat(miscFiles),
+  lint: miscFiles.concat(sourceFiles).concat(testFiles).concat(miscFiles),
+  src: sourceFiles,
   test: testFiles
 };