fix: prevent incorrect parsing of quoted strings in named placeholders #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update modifies the parsing logic in the named-placeholders module to ensure that quotes are only considered when not already inside a quoted string. This change addresses potential issues with parsing queries that contain quoted substrings, improving the overall reliability of the query parsing functionality.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the named-placeholders module's query parsing logic and sets up infrastructure to apply the patch automatically. The fix prevents incorrect parsing of quoted strings by ensuring the parser doesn't enter quote mode when already inside a quoted string.
Key Changes:
- Fixed quote parsing logic to check if already in a quoted context before opening a new quote
- Added patch-package infrastructure to automatically apply the fix during npm install
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| patches/named-placeholders+1.1.3.patch | Contains the patch fixing the quote parsing logic in the named-placeholders module |
| package.json | Adds patch-package dependencies and postinstall script to apply patches automatically |
Co-authored-by: Copilot <[email protected]>
durlabhjain
requested changes
Oct 16, 2025
Owner
durlabhjain
left a comment
durlabhjain
left a comment
There was a problem hiding this comment.
Test and update yarn.lock to remove dependencies of postinstall-postinstall
durlabhjain
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update modifies the parsing logic in the named-placeholders module to ensure that quotes are only considered when not already inside a quoted string. This change addresses potential issues with parsing queries that contain quoted substrings, improving the overall reliability of the query parsing functionality.