Skip to content

Commit 9fb72c2

Browse files
Upgrade PNPM to fix Validate (#218)
* Add Ignore to each package * Swap for yaml * Move to config * One more try * Fixed install * Test validate * Trying pnpm 11 instead * Next * Further fix
1 parent 9b45c58 commit 9fb72c2

21 files changed

Lines changed: 120 additions & 14 deletions

File tree

.github/workflows/measure-framework.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ jobs:
9292

9393
- name: Install package dependencies
9494
working-directory: ./packages/${{ matrix.framework.package }}
95-
run: pnpm install --frozen-lockfile --ignore-workspace
95+
run: pnpm install --frozen-lockfile
9696

9797
- name: Run build benchmark
9898
run: |
@@ -143,7 +143,7 @@ jobs:
143143

144144
- name: Install package dependencies
145145
working-directory: ./packages/${{ matrix.framework.package }}
146-
run: pnpm install --frozen-lockfile --ignore-workspace
146+
run: pnpm install --frozen-lockfile
147147

148148
- name: Build app
149149
working-directory: ./packages/${{ matrix.framework.package }}
@@ -184,7 +184,7 @@ jobs:
184184

185185
- name: Install package dependencies
186186
working-directory: ./packages/${{ matrix.framework.package }}
187-
run: pnpm install --frozen-lockfile --ignore-workspace
187+
run: pnpm install --frozen-lockfile
188188

189189
- name: Run e18e analysis
190190
working-directory: ./packages/${{ matrix.framework.package }}
@@ -226,7 +226,7 @@ jobs:
226226

227227
- name: Install package dependencies
228228
working-directory: ./packages/${{ matrix.framework.package }}
229-
run: pnpm install --frozen-lockfile --ignore-workspace
229+
run: pnpm install --frozen-lockfile
230230

231231
- name: Build app
232232
working-directory: ./packages/${{ matrix.framework.package }}
@@ -277,7 +277,7 @@ jobs:
277277

278278
- name: Install package dependencies
279279
working-directory: ./packages/${{ matrix.framework.package }}
280-
run: pnpm install --frozen-lockfile --ignore-workspace
280+
run: pnpm install --frozen-lockfile
281281

282282
- name: Build app
283283
working-directory: ./packages/${{ matrix.framework.package }}

.github/workflows/validate-stats.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
FRAMEWORKS=$(cat .github/frameworks.json)
3636
for PKG in $(echo "$FRAMEWORKS" | jq -r '.[].starter.package // empty, .[].app.package // empty'); do
3737
echo "Installing $PKG..."
38-
(cd packages/$PKG && pnpm install --frozen-lockfile --ignore-workspace)
38+
(cd packages/$PKG && pnpm install --frozen-lockfile)
3939
done
4040
4141
- name: Run all benchmarks and validate

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "0.0.1",
44
"private": true,
55
"type": "module",
6-
"packageManager": "pnpm@10.25.0",
6+
"packageManager": "pnpm@11.1.1",
77
"engines": {
88
"node": ">=24.0.0"
99
},
@@ -19,8 +19,8 @@
1919
"format:check": "prettier --check .",
2020
"type-check": "pnpm -r --parallel type-check",
2121
"type-check:all": "pnpm type-check && for pkg in packages/starter-* packages/app-*; do (cd \"$pkg\" && pnpm run --if-present type-check); done",
22-
"install:all": "for pkg in packages/starter-* packages/app-*; do (cd \"$pkg\" && pnpm install --ignore-workspace); done",
23-
"install:all:frozen": "for pkg in packages/starter-* packages/app-*; do (cd \"$pkg\" && pnpm install --frozen-lockfile --ignore-workspace); done",
22+
"install:all": "for pkg in packages/starter-* packages/app-*; do (cd \"$pkg\" && pnpm install); done",
23+
"install:all:frozen": "for pkg in packages/starter-* packages/app-*; do (cd \"$pkg\" && pnpm install --frozen-lockfile); done",
2424
"build:apps": "for pkg in packages/app-*; do echo \"Building $pkg...\" && (cd \"$pkg\" && pnpm build) || exit 1; done",
2525
"check:all": "pnpm install:all && pnpm format:check && pnpm lint:all && pnpm type-check:all",
2626
"check:all:ci": "pnpm install:all:frozen && pnpm format:check && pnpm lint:all && pnpm type-check:all"
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
packages:
2+
- .
3+
4+
allowBuilds:
5+
esbuild: true
6+
sharp: true
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
packages:
2+
- .
3+
4+
allowBuilds:
5+
esbuild: true
6+
sharp: true
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
packages:
2+
- .
3+
4+
allowBuilds:
5+
esbuild: true
6+
sharp: true
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
packages:
2+
- .
3+
4+
allowBuilds:
5+
esbuild: true
6+
sharp: true
7+
unrs-resolver: true
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
packages:
2+
- .
3+
4+
allowBuilds:
5+
'@parcel/watcher': true
6+
esbuild: true
7+
sharp: true
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
packages:
2+
- .
3+
4+
allowBuilds:
5+
esbuild: true
6+
sharp: true
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
packages:
2+
- .
3+
4+
allowBuilds:
5+
'@parcel/watcher': true
6+
esbuild: true
7+
sharp: true

0 commit comments

Comments
 (0)