Fix check_checksums when checksums are specified in JSON file

This requires correctly resolving the templates in `exts_list`
sources/patches to be able to fetch them from the JSON file.

Author: Flamefire

easybuild/framework/easyblock.py

@@ -2843,19 +2843,9 @@ def check_checksums(self):
         checksum_issues.extend(self.check_checksums_for(self.cfg))
 
         # also check checksums for extensions
-        with self.cfg.allow_unresolved_templates():
-            exts_list = self.cfg['exts_list']
-        for ext in exts_list:
-            # just skip extensions for which only a name is specified
-            # those are just there to check for things that are in the "standard library"
-            if not isinstance(ext, str):
-                ext_name = ext[0]
-                # take into account that extension may be a 2-tuple with just name/version
-                ext_opts = ext[2] if len(ext) == 3 else {}
-                # only a single source per extension is supported (see source_tmpl)
-                source_cnt = 1 if not ext_opts.get('nosource') else 0
-                res = self.check_checksums_for(ext_opts, sub="of extension %s" % ext_name, source_cnt=source_cnt)
-                checksum_issues.extend(res)
+        for ext in self.collect_exts_file_info(fetch_files=False, verify_checksums=False):
+            res = self.check_checksums_for(ext, sub=f"of extension {ext['name']}")
+            checksum_issues.extend(res)
 
         return checksum_issues
 

test/framework/easyblock.py

@@ -29,9 +29,11 @@
 @author: Kenneth Hoste (Ghent University)
 @author: Maxime Boissonneault (Compute Canada)
 @author: Jan Andre Reuter (Juelich Supercomputing Centre)
+@author: Alexander Grund (TU Dresden)
 """
 import copy
 import fileinput
+import itertools
 import os
 import re
 import shutil
@@ -3346,6 +3348,7 @@ def run_checks():
         run_checks()
 
         # full check also catches checksum issues with extensions
+        eb.json_checksums = {}  # Avoid picking up checksums from JSON file
         res = eb.check_checksums()
         self.assertEqual(len(res), 4)
         run_checks()
@@ -3482,6 +3485,12 @@ def run_checks():
                 ('ext-ok3', version, {
                     'nosource': True
                 }),
+                ('ext-ok1', version, {
+                    'checksums': ['44332000aa33b99ad1e00cbd1a7da769220d74647060a10e807b916d73ea27bc']
+                }),
+                ('ext-ok2', version, {
+                    'nosource': True
+                }),
             ]
         """)
         self.writeEC()
@@ -3492,6 +3501,27 @@ def run_checks():
         for ext, line in zip(extensions, res):
             self.assertIn(ext_error_tmpl % ext, line)
 
+        # Gradually add checksums to JSON dict and test that the associated extension checksums are now fine
+        sha256_cs = '81a3accc894592152f81814fbf133d39afad52885ab52c25018722c7bda92487'  # Valid format only
+        eb.json_checksums = {'ext1-0.0.tar.gz': sha256_cs}
+        for ext, line in itertools.zip_longest(extensions[1:], eb.check_checksums(), fillvalue=''):
+            self.assertIn(ext_error_tmpl % ext, line)
+        eb.json_checksums['ext2.zip'] = sha256_cs
+        for ext, line in itertools.zip_longest(extensions[1:], eb.check_checksums(), fillvalue=''):
+            self.assertIn(ext_error_tmpl % ext, line)
+        eb.json_checksums['ext2.patch'] = sha256_cs
+        for ext, line in itertools.zip_longest(extensions[2:], eb.check_checksums(), fillvalue=''):
+            self.assertIn(ext_error_tmpl % ext, line)
+        eb.json_checksums['ext3.zip'] = sha256_cs
+        for ext, line in itertools.zip_longest(extensions[2:], eb.check_checksums(), fillvalue=''):
+            self.assertIn(ext_error_tmpl % ext, line)
+        eb.json_checksums['ext3.patch'] = sha256_cs
+        for ext, line in itertools.zip_longest(extensions[3:], eb.check_checksums(), fillvalue=''):
+            self.assertIn(ext_error_tmpl % ext, line)
+        eb.json_checksums['ext-uniq_1-3.14.zip'] = sha256_cs
+        eb.json_checksums['ext-uniq_1.patch'] = sha256_cs
+        self.assertEqual(eb.check_checksums(), [])
+
         # more checks for check_checksums_for method, which also takes regular dict as input
         self.assertEqual(eb.check_checksums_for({}), [])
         expected = f"Checksums missing for one or more sources/patches in {os.path.basename(self.eb_file)}: "