Load dependencies of SYSTEM toolchain by full name

This allows loading e.g. `GCCcore/12.3.0/ncurses/6.1` without loading
the GCCcore/12.3.0 toolchain module.
So we can use that as a dependency.

Author: Flamefire

easybuild/tools/toolchain/toolchain.py

@@ -658,7 +658,10 @@ def _load_toolchain_module(self, silent=False):
 
     def _load_dependencies_modules(self, silent=False):
         """Load modules for dependencies, and handle special cases like external modules."""
-        dep_mods = [dep['short_mod_name'] for dep in self.dependencies]
+        # For SYSTEM software we allow using dependencies from any toolchain so we need to use the full
+        # module name to allow loading them in the hierarchical MNS
+        mod_name_key = 'full_mod_name' if self.is_system_toolchain() else 'short_mod_name'
+        dep_mods = [dep[mod_name_key] for dep in self.dependencies]
 
         if self.dry_run:
             dry_run_msg("\nLoading modules for dependencies...\n", silent=silent)
@@ -667,7 +670,7 @@ def _load_dependencies_modules(self, silent=False):
 
             # load available modules for dependencies, simulate load for others
             for dep, dep_mod_exists in zip(self.dependencies, mods_exist):
-                mod_name = dep['short_mod_name']
+                mod_name = dep[mod_name_key]
                 if dep_mod_exists:
                     self.modules_tool.load([mod_name])
                     dry_run_msg("module load %s" % mod_name, silent=silent)
@@ -683,15 +686,15 @@ def _load_dependencies_modules(self, silent=False):
             self.modules_tool.load(dep_mods)
 
             if self.dependencies:
-                build_dep_mods = [dep['short_mod_name'] for dep in self.dependencies if dep['build_only']]
+                build_dep_mods = [dep[mod_name_key] for dep in self.dependencies if dep['build_only']]
                 if build_dep_mods:
                     trace_msg("loading modules for build dependencies:")
                     for dep_mod in build_dep_mods:
                         trace_msg(' * ' + dep_mod)
                 else:
                     trace_msg("(no build dependencies specified)")
 
-                run_dep_mods = [dep['short_mod_name'] for dep in self.dependencies if not dep['build_only']]
+                run_dep_mods = [dep[mod_name_key] for dep in self.dependencies if not dep['build_only']]
                 if run_dep_mods:
                     trace_msg("loading modules for (runtime) dependencies:")
                     for dep_mod in run_dep_mods:
@@ -703,7 +706,7 @@ def _load_dependencies_modules(self, silent=False):
         self.modules.extend(dep_mods)
 
         # define $EBROOT* and $EBVERSION* for external modules, if metadata is available
-        for dep in [d for d in self.dependencies if d['external_module']]:
+        for dep in (d for d in self.dependencies if d['external_module']):
             mod_name = dep['full_mod_name']
             metadata = dep['external_module_metadata']
             self.log.debug("Metadata for external module %s: %s", mod_name, metadata)
@@ -862,7 +865,7 @@ def prepare(self, onlymod=None, deps=None, silent=False, loadmod=True,
         if deps is None:
             deps = []
         self.dependencies = self._check_dependencies(deps, check_modules=loadmod)
-        if not len(deps) == len(self.dependencies):
+        if len(deps) != len(self.dependencies):
             self.log.debug("dep %s (%s)" % (len(deps), deps))
             self.log.debug("tc.dep %s (%s)" % (len(self.dependencies), self.dependencies))
             raise EasyBuildError('Not all dependencies have a matching toolchain version')