Added command line parameter --fetch-all
#5014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update easyblock.py
Update options.py
Update config.py
Update main.py
boegel
changed the title
--fetch-continue
boegel
requested changes
Dec 7, 2025
easybuild/tools/options.py
Outdated
| False), | ||
| 'fetch': ("Allow downloading sources ignoring OS and modules tool dependencies, " | ||
| "implies --stop=fetch, --ignore-osdeps and ignore modules tool", None, 'store_true', False), | ||
| 'fetch-continue': ("Continue after failed fetch", None, 'store_true', False), |
Member
There was a problem hiding this comment.
Help text should make it clear that this implies --fetch, and I would rename this to --fetch-all maybe?
Suggested change
| 'fetch-continue': ("Continue after failed fetch", None, 'store_true', False), | |
| 'fetch-all': ("Download sources (like --fetch), don't stop when downloading failed for one easyconfig", | |
| None, 'store_true', False), |
easybuild/framework/easyblock.py
Outdated
| raise | ||
|
|
||
| @_obtain_file_update_progress_bar_on_return | ||
| def obtain_file_and_fail(self, filename, extension=False, urls=None, download_filename=None, force_download=False, |
Member
There was a problem hiding this comment.
method is a bit confusing maybe, how about:
Suggested change
| def obtain_file_and_fail(self, filename, extension=False, urls=None, download_filename=None, force_download=False, | |
| def obtain_file_raise_on_failure(self, filename, extension=False, urls=None, download_filename=None, force_download=False, |
Addressed comments from reviewer Boegel.
Rommelse
changed the title
--fetch-continue--fetch-all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added command line parameter --fetch-all. It implies --fetch. But when a fetch fails, EasyBuild will still try to fetch all dependencies. This is handy in situations where the success of fetching is non-deterministic and the engineer wants to get all failures at once without having to restart after each failure. Non-deterministic success of fetching can for example happen if some downloads are intercepted by the CyberDefence team to scan for vulnerabilities and later retries are handled by earlier scans that have been cached.