Debuging with ECD doesn't open the class in ECD on eclipse 2018-09 and later

[gayanper]

When debugging a class without the source (specially eclipse RCP application), when clicking on a stacktrace the file is not opened with ECD. Instead the file is opened with not source found class editor. As a workaround to get this working, i need to open the class which belongs in the debug stack by OpenType which opens the class in ECD, after closing it if i click the debug stack again, then file is opened in ECD and the debug line is highlighted.

[RobertZenz]

I believe that this should be a duplicate of #43.

[gayanper]

@RobertZenz i don't think they are exactly the same, because in this issue, "class without source" is set to ECD it self.

[helospark]

I occasionally see this also and it is quite annoying when happens.

It may have something to do with multiple projects/modules open with different version of the same jar (dependency) attached, but I don't really have a reliable repro for it.
Usually it helps if I close down other projects and restart the debugging.

[RobertZenz]

Mh, okay. Personally I haven't seen this so I'm not sure what to make of it.

[gayanper]

Will try to dig in if i find some time and post the details or a PR if possible

[davidmichaelkarr]

I occasionally see this also and it is quite annoying when happens.

It may have something to do with multiple projects/modules open with different version of the same jar (dependency) attached, but I don't really have a reliable repro for it.
Usually it helps if I close down other projects and restart the debugging.

Personally, the ECD is working fine for me, but I was helping a dev with a problem yesterday, and it was refusing to decompile a particular class for her. In fact, that class was available in two different versions of the artifact, with slightly different FQCNs, and neither was decompiling. When I attempted to open the same class in my Eclipse, it only saw one of the ones that she was seeing, and it had no trouble decompiling it. She has the same version of Eclipse and ECD that I have, and I believe the ECD configs are identical also. The difference here is the factor you allude to, with two different versions of the artifact in scope.

[RobertZenz]

@davidmichaelkarr There is a certain caching mechanism which I have not looked at, so maybe the cache got bad on that one and confused the plugin. But I'm not sure about that.

[helospark]

@davidmichaelkarr If this happens next time, please try to set "Search for duplicate source files on the path" option, I have a suspicion that it helps. You can set it like:
https://stackoverflow.com/a/23054379/8258222
(I was meaning to try this for a while myself, but lately I'm not working on projects, where this issue occurres)

[davidmichaelkarr]

On Tue, Jan 22, 2019 at 9:50 AM Helospark ***@***.***> wrote: @davidmichaelkarr <https://github.com/davidmichaelkarr> If this happens next time, please try to set "Search for duplicate source files on the path" option, I have a suspicion that it helps. You can set it like: https://stackoverflow.com/a/23054379/8258222

Note that when I was seeing this problem on the other dev's computer, we weren't even running in the debugger, we were just trying to inspect the decompiled source to see why a particular log message was coming out. We weren't in a situation where we could have stepped through the code in the debugger. All we did was do "Open Type" and enter the desired class name.

[jameyg42]

FYI - i had the same apparent behavior (fresh 2018-12 install, fresh workspace), and fixed the issue by simply marking ECD as the default editor for .class without source files

• Window -> Prefs -> General -> Editors -> File Associations
  .class without source
  click Class Decompiler Viewer; click Default
  (not sure how this relates to the "set default" setting under Java -> Decompiler prefs)

[gayanper]

I tried this with eclipse 4.14 and 4.15 milestone as well. And debugged the jdt code as well. Seems like jdt doesn’t even try to open the class file. I think thats because how the new source lookup happens.

I even had tried with a simple java project to see this. It didn’t worked

[jmiserez]

Unchecking the option Java -> Debug -> "Use advanced source lookup (JRE 1.5 and higher)" checkbox resolves this issue for me.

Just setting the default editor to the decompiler seems to work too, but I noticed that sometimes the wrong .class files would be decompiled when debugging.