Skip to content

Commit 9caa968

Browse files
committed
fixed javadoc errors discovered in release build
Signed-off-by: Thomas Jaeckle <[email protected]>
1 parent 18e493c commit 9caa968

File tree

5 files changed

+39
-6
lines changed

5 files changed

+39
-6
lines changed

base/model/src/main/java/org/eclipse/ditto/base/model/exceptions/UnsupportedMediaTypeException.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@
2020
import javax.annotation.concurrent.Immutable;
2121
import javax.annotation.concurrent.NotThreadSafe;
2222

23-
import org.eclipse.ditto.json.JsonObject;
2423
import org.eclipse.ditto.base.model.common.HttpStatus;
2524
import org.eclipse.ditto.base.model.headers.DittoHeaders;
2625
import org.eclipse.ditto.base.model.json.JsonParsableException;
26+
import org.eclipse.ditto.json.JsonObject;
2727

2828
/**
2929
* Thrown if a request with an unsupported media-type is made.
@@ -96,6 +96,7 @@ public static DittoRuntimeExceptionBuilder<UnsupportedMediaTypeException> withDe
9696
* about the actual used media-type and the description information about media-types are supported for the
9797
* requested resource.
9898
*
99+
* @param callersMediaType the actually used media-type.
99100
* @param mediaTypeSupportedByCalledResource media-types which are supported.
100101
* @return the new UnsupportedMediaTypeException.
101102
*/

base/model/src/main/java/org/eclipse/ditto/base/model/signals/acks/Acknowledgement.java

+1
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,7 @@ public Optional<JsonValue> getEntity(final JsonSchemaVersion schemaVersion) {
222222
/**
223223
* Sets the optional payload of the Acknowledgement.
224224
*
225+
* @param payload the payload to set as entity.
225226
* @return the Acknowledgement with set payload.
226227
* @since 1.2.0
227228
*/

base/model/src/main/java/org/eclipse/ditto/base/model/signals/commands/exceptions/GatewayTimeoutInvalidException.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@
2020
import javax.annotation.concurrent.Immutable;
2121
import javax.annotation.concurrent.NotThreadSafe;
2222

23-
import org.eclipse.ditto.json.JsonObject;
2423
import org.eclipse.ditto.base.model.common.HttpStatus;
2524
import org.eclipse.ditto.base.model.exceptions.DittoRuntimeException;
2625
import org.eclipse.ditto.base.model.exceptions.DittoRuntimeExceptionBuilder;
2726
import org.eclipse.ditto.base.model.headers.DittoHeaders;
2827
import org.eclipse.ditto.base.model.json.JsonParsableException;
28+
import org.eclipse.ditto.json.JsonObject;
2929

3030
/**
3131
* This exception indicates that the configured {@code "timeout"} of a HTTP call was not valid or within its allowed
@@ -60,6 +60,8 @@ private GatewayTimeoutInvalidException(final DittoHeaders dittoHeaders,
6060
/**
6161
* A mutable builder for a {@code GatewayTimeoutInvalidException}.
6262
*
63+
* @param timeout the applied timeout.
64+
* @param maxTimeout the configured max timeout.
6365
* @return the builder.
6466
*/
6567
public static Builder newBuilder(final Duration timeout, final Duration maxTimeout) {

base/model/src/main/java/org/eclipse/ditto/base/model/signals/events/GlobalEventRegistry.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,18 @@
1616

1717
import javax.annotation.concurrent.Immutable;
1818

19-
import org.eclipse.ditto.json.JsonMissingFieldException;
20-
import org.eclipse.ditto.json.JsonObject;
2119
import org.eclipse.ditto.base.model.json.JsonParsableEvent;
2220
import org.eclipse.ditto.base.model.signals.AbstractAnnotationBasedJsonParsableFactory;
2321
import org.eclipse.ditto.base.model.signals.AbstractGlobalJsonParsableRegistry;
2422
import org.eclipse.ditto.base.model.signals.JsonParsable;
23+
import org.eclipse.ditto.json.JsonMissingFieldException;
24+
import org.eclipse.ditto.json.JsonObject;
2525

2626
/**
2727
* Contains all strategies to deserialize subclasses of {@link Event} from a combination of
2828
* {@link org.eclipse.ditto.json.JsonObject} and {@link org.eclipse.ditto.base.model.headers.DittoHeaders}.
29+
*
30+
* @param <T> the event's type.
2931
*/
3032
@Immutable
3133
public final class GlobalEventRegistry<T extends Event<?>>
@@ -40,6 +42,7 @@ private GlobalEventRegistry() {
4042
/**
4143
* Gets an instance of GlobalEventRegistry.
4244
*
45+
* @param <T> the event's type.
4346
* @return the instance of GlobalEventRegistry.
4447
*/
4548
public static <T extends Event<?>> GlobalEventRegistry<T> getInstance() {

pom.xml

+28-2
Original file line numberDiff line numberDiff line change
@@ -284,10 +284,10 @@
284284
<plugin>
285285
<groupId>org.apache.maven.plugins</groupId>
286286
<artifactId>maven-javadoc-plugin</artifactId>
287-
<version>3.1.1</version>
287+
<version>3.2.0</version>
288288
<configuration>
289289
<javadocExecutable>${java.home}/bin/javadoc</javadocExecutable>
290-
<source>11</source>
290+
<detectJavaApiLink>false</detectJavaApiLink>
291291
</configuration>
292292
</plugin>
293293
<plugin>
@@ -726,6 +726,32 @@
726726
</build>
727727
</profile>
728728

729+
<profile>
730+
<id>createJavadoc</id>
731+
<activation>
732+
<property>
733+
<name>createJavadoc</name>
734+
<value>true</value>
735+
</property>
736+
</activation>
737+
<build>
738+
<plugins>
739+
<plugin>
740+
<groupId>org.apache.maven.plugins</groupId>
741+
<artifactId>maven-javadoc-plugin</artifactId>
742+
<executions>
743+
<execution>
744+
<id>attach-javadocs</id>
745+
<goals>
746+
<goal>jar</goal>
747+
</goals>
748+
</execution>
749+
</executions>
750+
</plugin>
751+
</plugins>
752+
</build>
753+
</profile>
754+
729755
<profile>
730756
<id>performRelease</id>
731757
<activation>

0 commit comments

Comments
 (0)