Skip to content

Commit c6a2c98

Browse files
committed
provided unit tests for "weak" eTag comparison recently fixed
1 parent 6a46766 commit c6a2c98

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

internal/utils/conditional-headers/src/test/java/org/eclipse/ditto/internal/utils/headers/conditional/IfMatchPreconditionHeaderTest.java

+7
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,13 @@ public void meetsCondition() {
5555
assertThat(ifMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("\"4711\""))).isTrue();
5656
}
5757

58+
@Test
59+
public void meetsConditionForWeak() {
60+
final IfMatchPreconditionHeader ifMatchPreconditionHeader =
61+
createIfMatchPreconditionHeader(fromCommaSeparatedString("W/\"4711\""));
62+
assertThat(ifMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("W/\"4711\""))).isTrue();
63+
}
64+
5865
@Test
5966
public void doesNotMeetConditionForNull() {
6067
final IfMatchPreconditionHeader ifMatchPreconditionHeader =

internal/utils/conditional-headers/src/test/java/org/eclipse/ditto/internal/utils/headers/conditional/IfNoneMatchPreconditionHeaderTest.java

+8
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,14 @@ public void doesNotMeetConditionForEqualOpaqueTag() {
5757
assertThat(ifNoneMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("W/\"4711\""))).isFalse();
5858
}
5959

60+
@Test
61+
public void doesNotMeetConditionForEqualOpaqueTagForWeak() {
62+
final IfNoneMatchPreconditionHeader ifNoneMatchPreconditionHeader =
63+
createIfNoneMatchPreconditionHeader(EntityTagMatchers.fromCommaSeparatedString("W/\"4711\""));
64+
assertThat(ifNoneMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("\"4711\""))).isTrue();
65+
assertThat(ifNoneMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("W/\"4711\""))).isFalse();
66+
}
67+
6068
@Test
6169
public void meetsConditionForNull() {
6270
final IfNoneMatchPreconditionHeader ifNoneMatchPreconditionHeader =

0 commit comments

Comments
 (0)