Skip to content

Commit d108b9e

Browse files
committed
#690: don't push docker image tag aliases for versions containing a "-" (e.g. 1.2.0-M2)
Signed-off-by: Thomas Jaeckle <[email protected]>
1 parent 42aadb2 commit d108b9e

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

Diff for: .github/workflows/push-dockerhub.yml

+10-5
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,14 @@ jobs:
2020
echo "::set-env name=IMAGE_TAG::${GITHUB_REF#refs/tags/}"
2121
echo "::set-env name=IMAGE_MINOR_TAG::$(echo ${GITHUB_REF#refs/tags/} | cut -d. -f-2)"
2222
echo "::set-env name=IMAGE_MAJOR_TAG::$(echo ${GITHUB_REF#refs/tags/} | cut -d. -f-1)"
23+
echo "::set-env name=MILESTONE_OR_RC_SUFFIX::$(echo ${GITHUB_REF#refs/tags/} | cut -d- -f2)"
2324
- name: Building Docker images for tag
2425
run: |
2526
echo $IMAGE_TAG
2627
echo "Full version: $IMAGE_TAG"
2728
echo "Minor version: $IMAGE_MINOR_TAG"
2829
echo "Major version: $IMAGE_MAJOR_TAG"
30+
echo "Milestone or RC suffix: $MILESTONE_OR_RC_SUFFIX"
2931
- name: Build the Docker images
3032
run: |
3133
docker build -f services/dockerfile-release --build-arg SERVICE_STARTER=ditto-services-policies-starter --build-arg SERVICE_VERSION=$IMAGE_TAG -t eclipse/ditto-policies:$IMAGE_TAG -t eclipse/ditto-policies:$IMAGE_MINOR_TAG -t eclipse/ditto-policies:$IMAGE_MAJOR_TAG -t eclipse/ditto-policies:latest .;
@@ -39,26 +41,29 @@ jobs:
3941
- name: Push the Docker images to Docker Hub
4042
run: |
4143
docker push eclipse/ditto-policies:$IMAGE_TAG;
44+
docker push eclipse/ditto-things:$IMAGE_TAG;
45+
docker push eclipse/ditto-things-search:$IMAGE_TAG;
46+
docker push eclipse/ditto-concierge:$IMAGE_TAG;
47+
docker push eclipse/ditto-gateway:$IMAGE_TAG;
48+
docker push eclipse/ditto-connectivity:$IMAGE_TAG;
49+
- name: Push the Docker images of tag aliases to Docker Hub
50+
if: env.MILESTONE_OR_RC_SUFFIX == env.IMAGE_TAG
51+
run: |
4252
docker push eclipse/ditto-policies:$IMAGE_MINOR_TAG;
4353
docker push eclipse/ditto-policies:$IMAGE_MAJOR_TAG;
4454
docker push eclipse/ditto-policies:latest;
45-
docker push eclipse/ditto-things:$IMAGE_TAG;
4655
docker push eclipse/ditto-things:$IMAGE_MINOR_TAG;
4756
docker push eclipse/ditto-things:$IMAGE_MAJOR_TAG;
4857
docker push eclipse/ditto-things:latest;
49-
docker push eclipse/ditto-things-search:$IMAGE_TAG;
5058
docker push eclipse/ditto-things-search:$IMAGE_MINOR_TAG;
5159
docker push eclipse/ditto-things-search:$IMAGE_MAJOR_TAG;
5260
docker push eclipse/ditto-things-search:latest;
53-
docker push eclipse/ditto-concierge:$IMAGE_TAG;
5461
docker push eclipse/ditto-concierge:$IMAGE_MINOR_TAG;
5562
docker push eclipse/ditto-concierge:$IMAGE_MAJOR_TAG;
5663
docker push eclipse/ditto-concierge:latest;
57-
docker push eclipse/ditto-gateway:$IMAGE_TAG;
5864
docker push eclipse/ditto-gateway:$IMAGE_MINOR_TAG;
5965
docker push eclipse/ditto-gateway:$IMAGE_MAJOR_TAG;
6066
docker push eclipse/ditto-gateway:latest;
61-
docker push eclipse/ditto-connectivity:$IMAGE_TAG;
6267
docker push eclipse/ditto-connectivity:$IMAGE_MINOR_TAG;
6368
docker push eclipse/ditto-connectivity:$IMAGE_MAJOR_TAG;
6469
docker push eclipse/ditto-connectivity:latest;

0 commit comments

Comments
 (0)