Idempotency feature on DSP is actually doing nothing

[ndr-brt]

Feature Request

Some time ago we implemented idempotency on the DSP layer so duplicate messages can be deduplicated.

This feature was based on the assumption that the DSP messages bring an unique @id, but this is not the case, according to the DSP 2025/1 spec.

In fact, the ProcessRemoteMessage, the abstraction for all the DSP messages, has a "if null, set random" id logic:

Connector/spi/common/core-spi/src/main/java/org/eclipse/edc/spi/types/domain/message/ProcessRemoteMessage.java

Lines 123 to 126 in 52cec0c

	if (message.id == null) {
	message.id = randomUUID().toString();
	}
	return super.build();

that means that every message will be different from the previous.

Solution Proposal

My proposal is to chop off this feature as it brings no real value at the moment

[ndr-brt]

A discussion in the spec repo has been opened: eclipse-dataspace-protocol-base/DataspaceProtocol#257

[github-actions]

This issue is stale because it has been open for 14 days with no activity.

[ndr-brt]

this is in discussion in the upstream DSP project: eclipse-dataspace-protocol-base/DataspaceProtocol#260
likely it will end up in a new messageId attribute, so we'll need to change the current implementation a bit