Bug Report
Describe the Bug
Looking at the protocol services, there are some "break lease" missing, especially when message deduplication is triggered.
This is in part caused in the not great shape these services have become, they need some refactoring.
Expected Behavior
after a new entity is fetched with lease, there should be either a save or a breakLease call before returning the result.
Possible Implementation
add clear separation between business logic (that always succeeds and store the changes) and business validations/guards, that will require the lease to be broken, that will make all the flow and responsibilities clearer.
Bug Report
Describe the Bug
Looking at the protocol services, there are some "break lease" missing, especially when message deduplication is triggered.
This is in part caused in the not great shape these services have become, they need some refactoring.
Expected Behavior
after a new entity is fetched with lease, there should be either a
saveor abreakLeasecall before returning the result.Possible Implementation
add clear separation between business logic (that always succeeds and store the changes) and business validations/guards, that will require the lease to be broken, that will make all the flow and responsibilities clearer.